| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | ChanServ sets mode: +v pinchartl | [08:56] |
| ...................................... (idle for 3h5mn) | ||
| Guest5855 | hi all | [12:01] |
| mchehab | internet is really bad here today | [12:01] |
| mkrufky | :waves: | [12:02] |
| mchehab | I guess today will be our last meeting before Seasons
I guess hverkuil is already in vacations. pinchartl, mkrufky, sailus, syoung: anything for today's discussions? mchehab would like to do a quick meeting today... I'm using my 4G mobile for today's meeting, as the wired connection is very poor today | [12:02] |
| mkrufky | I came in to say hello - it's been too long. I had my surgery and I am fine now.
but I do have a message from Brad | [12:04] |
| mchehab | mchehab hopes Brad's message is a good thing, like Happy Christmas, or something similar :-D | [12:05] |
| mkrufky | He pinged me and asked me to look at the exchange between him and Antti on Brad's recent patch series...
I didnt read it all, but I saw one, where Brad is improving hybrid tuning support, just like all other drivers Antti doesnt seem to like our hybrid tuner system. He criticizes the work and nack's the patch ... | [12:05] |
| mchehab | Subject: Re: [PATCH v3 02/14] si2157: Check error status bit on cmd execute | [12:06] |
| mkrufky | i think we all can agree that the hybrid tuner stuff isnt ideal, but it works | [12:06] |
| mchehab | this patch series? | [12:06] |
| mkrufky | yes i think so
Anyway, so He asks for others to take a look, because Antti is Nacking without providing any alternatives or suggestions Brad is happy to make changes, but he doesnt know what he can do to make Antti happy I invited him to join this IRC but it's too early in the AM for him look at this one: [PATCH v3 04/14] si2157: Add analog tuning related functions | [12:06] |
| mchehab | I did a real quick look at the antti's comments. it sounded to me that, except for patch 4/14, Antti's comments seem to have some technical rationale
his comment to 12/14 is probably because he is not too familiar with the hybrid design it sounds to me that only patch 4/14 need further discussions. | [12:10] |
| mkrufky | it's funny because 4/14 is the one i saw first
i agree with you - the others seem fine at a quick glance | [12:11] |
| mchehab | If i read it well, I would suggest Brad to move 4/14 to the end, sending a v4 without it | [12:12] |
| hverkuil | mchehab: PR https://patchwork.linuxtv.org/patch/60699/ is marked as Accepted, but does not appear to be merged. I'm changing the state back to New.
The only other outstanding PR is https://patchwork.linuxtv.org/patch/60777/ for the y2038 patches. | [12:12] |
| mchehab | then open a separate series for patch 4/14 | [12:12] |
| mkrufky | I think that's good advice. I'll suggest it to Brad - thanks | [12:12] |
| mchehab | I can discuss futher with Brad about that, if needed. unfortunately, crope is currently not too active at the chat
hverkuil: I remember I reviewed one patch from Gallo perhaps I just forgot to update it yeah, I didn't review y2038 patch series yet commit 69e39d40587b8d7538f966607299c360dc935b1f Author: Guilherme Alcarde Gallo <gagallo7@gmail.com> Date: Sun Nov 10 19:33:21 2019 +0100 media: vimc: Implement get/set selection in sink it is on my tree here | [12:13] |
| hverkuil | Huh, they are merged, but the patches in the PR are still marked as "Under Review" in patchwork. | [12:16] |
| mchehab | https://git.linuxtv.org/media_tree.git/commit/?id=69e39d40587b8d7538f966607299c360dc935b1f | [12:16] |
| hverkuil | ah, and this patch was probably accepted when the media-commit ML was broken, so I never saw them there. | [12:16] |
| mchehab | my script will only change the patches if the md5sum of the diff is identical
yeah,maybe so, it sounds that only y2038 patch series is missing merge | [12:16] |
| hverkuil | I'll move the status back to "Accepted".
Yes. | [12:17] |
| mchehab | I'll try to handle it soon, but Internet here is too bad... maybe I'll handle y2038 patches during the weekend | [12:17] |
| hverkuil | you have under 2038 to handle them :-)
until | [12:18] |
| mchehab | :-)
that's really a "non-urgent" pull request... we have so many years to apply it ;-) anyway, I prefer to finish all 2019 tasks before Seasons | [12:18] |
| hverkuil | That would make Arnd happy :-) | [12:19] |
| mchehab | that reminds that I should be OOT between Dec, 24 to Jan, 1
I usually work along days, but this time I'm intending to rest as a reminder, our next weekly meeting will be on Jan, 6th | [12:20] |
| hverkuil | Enjoy your vacation! | [12:24] |
| mchehab | thanks! you too | [12:32] |
| .......... (idle for 48mn) | ||
| *** | ChanServ sets mode: +v mchehab | [13:20] |
| ........................................................ (idle for 4h38mn) | ||
| mkrufky has left | [17:58] | |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |