<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>

   Guest5855: hi all
   mchehab: internet is really bad here today
   mkrufky: :waves:
   mchehab: I guess today will be our last meeting before Seasons
   <br> I guess hverkuil is already in vacations. pinchartl, mkrufky, sailus, syoung: anything for today's discussions?
   -: mchehab would like to do a quick meeting today... I'm using my 4G mobile for today's meeting, as the wired connection is very poor today
   mkrufky: I came in to say hello - it's been too long.   I had my surgery and I am fine now.
   <br> but
   <br> I do have a message from Brad
   -: mchehab hopes Brad's message is a good thing, like Happy Christmas, or something similar :-D
   mkrufky: He pinged me and asked me to look at the exchange between him and Antti on Brad's recent patch series...
   <br> I didnt read it all, but I saw one, where Brad is improving hybrid tuning support, just like all other drivers
   <br> Antti doesnt seem to like our hybrid tuner system.  He criticizes the work and nack's the patch
   <br> ...
   mchehab: <u>Subject</u>: Re: [PATCH v3 02/14] si2157: Check error status bit on cmd execute
   mkrufky: i think we all can agree that the hybrid tuner stuff isnt ideal, but it works
   mchehab: this patch series?
   mkrufky: yes i think so
   <br> Anyway, so He asks for others to take a look, because Antti is Nacking without providing any alternatives or suggestions
   <br> Brad is happy to make changes, but he doesnt know what he can do to make Antti happy
   <br> I invited him to join this IRC but it's too early in the AM for him
   <br> look at this one:  [PATCH v3 04/14] si2157: Add analog tuning related functions
   mchehab: I did a real quick look at the antti's comments. it sounded to me that, except for patch 4/14, Antti's comments seem to have some technical rationale
   <br> his comment to 12/14 is probably because he is not too familiar with the hybrid design
   <br> it sounds to me that only patch 4/14 need further discussions.
   mkrufky: it's funny because 4/14 is the one i saw first
   <br> i agree with you - the others seem fine at a quick glance
   mchehab: If i read it well, I would suggest Brad to move 4/14 to the end, sending a v4 without it
   hverkuil: <u>mchehab</u>: PR https://patchwork.linuxtv.org/patch/60699/ is marked as Accepted, but does not appear to be merged. I'm changing the state back to New.
   <br> The only other outstanding PR is https://patchwork.linuxtv.org/patch/60777/ for the y2038 patches.
   mchehab: then open a separate series for patch 4/14
   mkrufky: I think that's good advice.   I'll suggest it to Brad - thanks
   mchehab: I can discuss futher with Brad about that, if needed. unfortunately, crope is currently not too active at the chat
   <br> <u>hverkuil</u>: I remember I reviewed one patch from Gallo
   <br> perhaps I just forgot to update it
   <br> yeah, I didn't review y2038 patch series yet
   <br> commit 69e39d40587b8d7538f966607299c360dc935b1f
   <br> <u>Author</u>: Guilherme Alcarde Gallo &lt;gagallo7@gmail.com&gt;
   <br> <u>Date</u>:   Sun Nov 10 19:33:21 2019 +0100
   <br> <u>media</u>: vimc: Implement get/set selection in sink
   <br> it is on my tree here
   hverkuil: Huh, they are merged, but the patches in the PR are still marked as "Under Review" in patchwork.
   mchehab: https://git.linuxtv.org/media_tree.git/commit/?id=69e39d40587b8d7538f966607299c360dc935b1f
   hverkuil: ah, and this patch was probably accepted when the media-commit ML was broken, so I never saw them there.
   mchehab: my script will only change the patches if the md5sum of the diff is identical
   <br> yeah,maybe
   <br> so, it sounds that only y2038 patch series is missing merge
   hverkuil: I'll move the status back to "Accepted".
   <br> Yes.
   mchehab: I'll try to handle it soon, but Internet here is too bad... maybe I'll handle y2038 patches during the weekend
   hverkuil: you have under 2038 to handle them :-)
   <br> until
   mchehab: :-)
   <br> that's really a "non-urgent" pull request... we have so many years to apply it ;-)
   <br> anyway, I prefer to finish all 2019 tasks before Seasons
   hverkuil: That would make Arnd happy :-)
   mchehab: that reminds that I should be OOT between Dec, 24 to Jan, 1
   <br> I usually work along days, but this time I'm intending to rest
   <br> as a reminder, our next weekly meeting will be on Jan, 6th
   hverkuil: Enjoy your vacation!
   mchehab: thanks! you too
   ***: ChanServ sets mode: +v mchehab
   <br> mkrufky has left