hi all (today I'm a bit short of time... I have just ~20 mins for discussions) hi! btw, I won't be able to join our meeting next week... will be on a biztrip without Internet access hverkuil: I still have some patches from one of your PRs on my queue (the ones after that /4 patch series we've discussed yesterday) I intend to handle it later today hverkuil, pinchartl, sailus, syoung: anything for today's discussion? syoung: I also intend to handle your DVB patch series today ok. I think it's best to just drop the /4 series and apply everything else from that PR. I'll likely make a new PR tomorrow for the staging rkisp1 driver. v13 seems to be the lucky version :-) :-) as I won't have internet access next week, I hope not many PRs will arrive... as otherwise they may be applied only for 5.7 I get try to push that PR out today, if you prefer? (I'll likely apply pending PRs on Jan, 20 - but if there are too many things, some stuff may end being postponed) tomorrow should be fine, if you can do it during the morning are you back in Brazil, or still in Germany? still in DE anything else for today's meeting? Not from me. ok. if someone pops up, I'll read the backlog and reply after lunch.] hverkuil: regarding the rkisp1 driver what's your opinion on how they handle ISP parameters ? they're put in a buffer queued to a parameters queue but it's then entirely consumed by the driver to write registers, the buffer isn't passed to the hardware It's a valid choice, but not necessarily the best choice. I'd have chosen compound controls for this. The only advantage of using a buffer is that can do zero-copy, whereas a control always involves a memcpy. there are performance concerns, and the fact that we have no format support in the request API Performance concerns with what? Using buffers or using controls? I suspect that the uapi for the driver need improvements... as it is now at staging, I'm blindly accepting it but I want to understand and see it properly documented before moving out of staging anyway, the pending PRs were applied hverkuil: with using controls mchehab: agreed, for staging it's fine