<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>

   mchehab: IMHO, it makes more sense to include CEC Kconfig outside MEDIA_SUPPORT
   hverkuil: <u>mchehab</u>: it doesn't apply on top of the master branch. Does it depend on something else?
   <br> i.e. the revert patch preceding it?
   <br> ah yes.
   <br> BTW, if I disable "Filter media drivers", shouldn't the "Media device types" line disappear in the menu? Now it remains as an empty menu, which is ugly and confusing.
   <br> Also, I think that the "Filter media drivers" should be just before the "Media device types" to indicate a direct relationship. Same for the Autoselect ancillary drivers: that should be just before the "Media ancillary drivers" menu.
   <br> In any case, with that patch it looks like I can't select the media CEC drivers anymore.
   <br> MEDIA_CEC_SUPPORT can't be selected anymore.
   mchehab: ok, let's go by parts...
   <br> there are some troubles with Kconfig support and "visible"
   <br> when a menu is not visible, it doesn't always parse the invisible options properly
   <br> that's why I kept the empty menu
   <br> 2) we can always reorder things. yeah, it could make sense to do some reorder there
   <br> I'd like to ensure that the comments added at .config to be consistent
   <br> that's why I opted to keep all core options together,
   <br> also, it sounds more natural to me to first select core options. That's why I placed all driver-specific options at the end
   <br> 3) MEDIA_CEC_SUPPORT: good point
   <br> IMHO, we should place all pure-CEC drivers outside the MEDIA_SUPPORT menu, as they don't really depend on it
   hverkuil: I have no problems with that.
   mchehab: hmm... looking at (3), that would probably require moving pure CEC drivers to a separate place
   <br> I mean, if we place MEDIA_CEC_SUPPORT outside MEDIA_SUPPORT, the drivers should also be an independent menu
   <br> referenced by media/cec/Kconfig
   <br> so, cec drivers should likely go under media/cec/*
   hverkuil: If we want to do that, then media/cec should become media/cec-core and media/cec can then be used for the pure cec drivers.
   mchehab: well, on "rc", we just put drivers and core together
   hverkuil: Unrelated comment: we're not using _ in directory names, so would it be possible to rename test_drivers to test-drivers?
   mchehab: <u>hverkuil</u>: works for me
   hverkuil: instead of media/cec-core it could also be media/cec/core
   <br> I do want to keep the core framework in its own directory, not mixed in with the cec drivers.
   mchehab: another alternative would be to have the core at media/cec, and have a media/cec/drivers
   hverkuil: drivers/media/cec/drivers?  Yuck.
   mchehab: heh
   <br> well, drivers/media/cec/platform and drivers/media/cec/usb
   hverkuil: and drivers/media/cec/core for the core framework. Works for me.
   mchehab: I would just keep the core at drivers/media/cec
   <br> and drivers under drivers/media/&lt;bus&gt;
   <br> but if you insist, I can live with cec/core
   hverkuil: we don't do that for other frameworks either (v4l2-core, dvb-core, etc). So I prefer cec/core.
   mchehab: ok
   <br> I'll prepare the changesets
   hverkuil: Thank you.
   <br> I think I fixed media_build after all the changes from yesterday. The spec should now also be built correctly (I hope)
   mchehab: good!
   <br> send a second version
   <br> jst noticed that it is still incomplete...
   <br> it would make sense to also move I2C drivers
   <br> s/would/could/
   <br> nah, it doesn't
   <br> CEC support here are optional features for video drivers
   <br> please review patch 3 with some care.... there are several drivers that aren't under media/platform
   <br> (like VIDEO_CROS_EC_CEC)
   <br> hmm... just found it... I'll send a third version
   <br> <u>hverkuil</u>: new version sent. I guess this one should be ok
   hverkuil: <u>mchehab</u>: I'm testing that version, will have the results soon.
   <br> One note about the "Media ancillary drivers" menu:
   <br> At the top it has a submenu "I2C Encoders, decoders, sensors and other helper chips", but that does not actually contain sensors.
   <br> I think moving all sensors to their own submenu would clean things up. Lens and Flash drivers should probably be moved there as well.
   mchehab: yeah, makes sense to have camera-related I2C on a separate sub-menu
   <br> I would keep them under i2c dir, at least for now
   <br> I'll take a look at the I2C Kconfig and see how it can be improved
   <br> thanks for the ack. Merged
   <br> <u>hverkuil</u>: just submitted a patch for I2C menus
   <br> in order to be able to fully test it, don't forget to disable EXPERT and EMBEDDED
   <br> as those two Kconfig options control the visibility of the ancillary drivers menu