| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| hverkuil | mchehab: https://patchwork.linuxtv.org/patch/63293/
Can you apply asap? The rkisp1 driver currently fails to compile, and this fixes it. Let me repost this patch with a better subject line. mchehab: updated patch: https://patchwork.linuxtv.org/patch/63295/ | [11:07] |
| mchehab | hverkuil: sure
will apply right now | [11:20] |
| patch applied, together with a MAINTAINERS file fix from Ezequiel | [11:26] | |
| hverkuil | Ah, good. Thank you!
Let's see if the daily build is now OK. syoung: smatch errors: smatch: ERRORS /home/hans/work/build/media-git/drivers/media/tuners/si2157.c: /home/hans/work/build/media-git/drivers/media/tuners/si2157.c:351 si2157_tune_wait() error: uninitialized symbol 'wait_status'. /home/hans/work/build/media-git/drivers/media/tuners/si2157.c: /home/hans/work/build/media-git/drivers/media/tuners/si2157.c:378 si2157_tune_wait() error: uninitialized symbol 'wait_status'. Can you take a look? | [11:27] |
| .................................................. (idle for 4h8mn) | ||
| mchehab | hmm... that is likely related to analog support that got added, via syoung's tree
weird... there's no wait_status upstream perhaps some media-build patch is adding it | [15:38] |
| ............. (idle for 1h2mn) | ||
| hverkuil | drivers/media/tuners/si2157.c definitely has wait_status. Those errors are from smatch against our master branch.
I think is just needs to be initialized to 0. | [16:42] |
| ............................. (idle for 2h23mn) | ||
| syoung | hverkuil: smatch can't assume that the body of the while loop is ever executed. Maybe a better solution is to change it into a do {} while () | [19:06] |
| ....................... (idle for 1h50mn) | ||
| hverkuil: I've sent a patch for this to the list | [20:56] | |
| ............. (idle for 1h1mn) | ||
| mchehab | syoung: patch makes sense to me. I would use, instead of "for (;;;)" a "while (1)" | [21:57] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |