[11:56] <syoung> hi all
[11:59] <syoung> hverkuil, mchehab: I wanted to ask what you thought of https://patchwork.linuxtv.org/project/linux-media/patch/20200722203217.GA720@gofer.mess.org/
[11:59] <hverkuil> hi all
[11:59] <mchehab> hi all
[12:00] <hverkuil> syoung: I'll look at this later today/tomorrow.
[12:01] <mchehab> syoung: I like the idea, but it sounds that there's an issue there
[12:01] <hverkuil> +1 for the idea as well :-)
[12:01] <mchehab> +TOPSRCDIR="$( cd "$( dirname "$0" )" && pwd )"
[12:02] <mchehab> this is not true, depending on how the ./configure parameters are passed
[12:02] <mchehab> the script needs, instead, @abstopdir@ (or something similar - don't remember the exact name)
[12:04] <mchehab> I would also add a "set -e" at the script
[12:04] <mchehab> in order to prevent it to do the wrong thing if something goes bad...
[12:04] <mchehab> like cd <foo dir>
[12:05] <mchehab> basically, if you want to use a script, you need to ensure to use the automake tools to pass both the source dir and the abs dir to the script
[12:05] <mchehab> ops
[12:05] <mchehab> basically, if you want to use a script, you need to ensure to use the automake tools to pass both the source dir and the dest dir to the script
[12:06] <syoung> mchehab: the idea is to make it independent from autotools
[12:06] <syoung> (if possible)
[12:07] <mchehab> "@abs_top_srcdir@"
[12:07] <mchehab> "@abs_top_builddir@"
[12:07] <mchehab> you can't make it fully independent
[12:08] <syoung> why not?
[12:08] <mchehab> as otherwise, it will fail to build with some distros
[12:08] <mchehab> debian and fedora, for example, use completely different settings for configure
[12:08] <mchehab> calling it with different srcdir and builddir
[12:09] <mchehab> what you can do is to run the script like:
[12:09] <mchehab> ./script "@abs_top_srcdir@" "@abs_top_builddir@"
[12:10] <mchehab> btw, you may even need to do:
[12:10] <syoung> the script doesn't need to be procesed by autotools. It can just exists as-is
[12:10] <mchehab> "@abs_top_srcdir@/script" "@abs_top_srcdir@" "@abs_top_builddir@"
[12:11] <mchehab> hmm... good point
[12:11] <syoung> a bit like bootstrap.sh
[12:12] <mchehab> yeah, I guess it makes sense
[12:12] <mchehab> as this is used only by devs
[12:13] <syoung> exactly
[12:13] <mchehab> but, in this case, it should expect one parameter: KERNEL_DIR
[12:13] <mchehab> and you need to update the docs
[12:14] <syoung> yes, that makes sense.
[12:14] <syoung> Thanks, I'll do that.
[12:14] <syoung> what docs need updating?
[12:15] <syoung> Ah, README.md
[12:15] <syoung> or README
[12:16] <mchehab> yeah, the readme file (whatever name is :-) )
[12:17] <syoung> thanks, that's all I had.
[12:18] <mchehab> anything else?
[12:19] <hverkuil> There is one outstanding PR from me. I hope to have one or two more today/tomorrow (with a bit of luck the tegra sensor support can be merged)
[12:19] <hverkuil> I don't have anything else.
[12:20] <mchehab> ok. I'll likely handle remaining patches this weekend
[12:20] <hverkuil> Nothing else from me.
[12:20] <mchehab> as usual, in principle, next week we're frozen for new merges (except bug fixes)
[12:22] <mchehab> (I may reconsider if Linus decides to extend this -rc cycle)
[22:07] *** ChanServ sets mode: +v hverkuil