[06:03] *** ChanServ sets mode: +v hverkuil [08:08] <hverkuil> mchehab: can you apply this patch? [08:08] <hverkuil> https://patchwork.linuxtv.org/project/linux-media/patch/7a17b41b-f7e2-268e-36fa-deae431454a4@xs4all.nl/ [08:08] <hverkuil> Without it I can't enable vidtv with 'make menuconfig'. [08:16] <mchehab> hverkuil: thanks for reporting it so quickly! [08:16] <mchehab> patch applied [08:17] <hverkuil> Thanks! I'll enable it for the next daily build. [08:17] <mchehab> ok, thanks! [08:17] <mchehab> btw, it will produce some pr_fmt() warnings at media_build [08:17] <mchehab> I'm considering changing pr_foo() to dev_foo() there [08:18] <mchehab> instead of fixing media_build [08:19] <hverkuil> it's very easy to fix media_build, so don't bother on my account. [08:30] <hverkuil> mchehab: I'm getting warnings in vidtv when compiling for 32 bit. Replied to the cover letter with the warnings. [08:30] <hverkuil> 64 bit is fine. [08:30] <hverkuil> Also fixed media_build. [08:38] <mchehab> hverkuil: well, the thing is that I prefer using dev_foo instead of pr_foo :-) [08:39] <mchehab> anyway, at least some of them will be painful to replace [08:39] <mchehab> btw, I expect it may have troubles building on random archs [08:39] <mchehab> as the files aren't including kernel.h, but instead several headers [08:39] <mchehab> like linux/printk.h [08:40] <mchehab> I'll address the 32 bit ones [08:40] <mchehab> and probably do some cleanups at includes [09:16] <mchehab> 32-bit warnings fixed [13:57] <pinchartl> speaking of media_build, I've had a crash recently caused by dma-buf.h being copied from the media tree [13:57] <pinchartl> I'm running kernel v5.4.60 [13:57] <pinchartl> and in the latest kernel dma_buf_ops has gained a few new operations [13:57] <pinchartl> the dmabuf core can't be compiled as a module, so it runs with the v5.4.60 version of that structure [13:58] <pinchartl> while media_build uses a newer version [13:58] <pinchartl> that doesn't work well quite obviously