[22:44] *** headless has quit IRC (Quit: headless) [01:10] <pinchartl> mchehab: ping [01:35] <pinchartl> mchehab: I've reviewed v6 [01:36] <pinchartl> I haven't commented on 4/8 and 5/8, but the comments I made on patches 1/8 to 4/8 apply there [01:42] <mchehab> pinchartl: thanks for the review. I'll take a look on them tomorrow [11:36] <mchehab> pinchartl: FYI, we can't use ftrace due to things like: http://pastebin.com/3v2T2Wt0 [11:43] <ribalda> hverkuil: Hello, thanks for your review! [11:44] <ribalda> one fast question. Can I modify saa7164 so it accespts CLASS_MPEG and V4L2_CTRL_WHICH_CUR_VAL ? [11:46] <hverkuil> ribalda: I wouldn't spend time on it. It should be converted to the control framework instead. [11:48] <ribalda> it is not a big deal. Takes two second to change it [11:53] <hverkuil> don't bother. Leaving this out is just another incentive to finally convert this driver. [12:50] <hverkuil> ribalda: I'm working on a quick saa7164 conversion to the ctrl framework. [12:50] <hverkuil> couldn't stand it anymore :-) [12:55] <ribalda> hverkuil: could you take a fast look to this? https://github.com/ribalda/linux/commit/41e45f8c4ae61e26f72e94d6bb92566790e1b95a [12:55] <ribalda> is this what you mean on your first mail? [12:57] <hverkuil> ribalda: yes, but you forgot to do the same update in Documentation/ [12:57] <hverkuil> Just do a git grep on the full kernel so you're certain you got it all. [12:58] <hverkuil> Note: the only place where ctrl_class should still appear is in the VIDIOC_G_EXT_CTRLS DocBook documentation. [13:00] <ribalda> hverkuil: Better now? https://github.com/ribalda/linux/commit/e801d93820d31ce7aafc610a620e7610f860f0a8 [13:02] <hverkuil> yes [13:03] <ribalda> ok, I pack it and ship it as v2. Thanks for the hyperfast review :). [13:03] <hverkuil> oh, one more: [13:03] <hverkuil> in v4l2-ioctl.c, v4l_print_ext_controls, the pr_cont call uses "class=0x%x", that should become "which=0x%x" [13:04] <ribalda> goot catch, sorry about that [16:31] <pinchartl> mchehab: I'm not sure to see why that prevents using ftrace :-) [16:32] <mchehab> did you see my email? [16:32] <mchehab> need to get this at serial console, before Kernel hangs [16:32] <mchehab> due to some OOPS [16:33] <mchehab> and printed debug messages should be displayed at the order they occur [16:33] <pinchartl> no I haven't checked the e-mails yet [16:37] <mchehab> pinchartl: btw, you mentioned about DocBook compilation on one of the emails... where are the media controller DocBook header files located after calling make htmldocs? [16:38] <pinchartl> mchehab: good question :-) [16:38] <pinchartl> let me check [16:39] <pinchartl> (I'm in a meeting so I'll be a bit slow) [16:43] <mchehab> I tried here: [16:43] <mchehab> ack -a media_entity_operations Documentation/DocBook/ [16:43] <mchehab> but it didn't find anything [16:43] <pinchartl> it might not be there [16:43] <mchehab> and media_entity_operations has the tags [16:43] <pinchartl> by the way make htmldocs fails on the media docbook on master :-/ [16:43] <mchehab> just fixed that [16:43] <pinchartl> ok :-) [16:44] <pinchartl> let me pull [16:44] <mchehab> a </para> missing [16:44] <mchehab> I sent the patch [16:44] <mchehab> not merged upstream yet [16:44] <pinchartl> ok [16:44] <pinchartl> let me apply it then :-) [16:44] <mchehab> ok [16:55] <pinchartl> make htmldocs still fails :-/ [16:55] <mchehab> well, make htmldocs currently causes *LOTS* of warnings [16:55] <mchehab> due to a bug at htmlto [16:56] <mchehab> s/htmlto/xmlto/ [16:56] <mchehab> what I do to generate the main xml is: [16:56] <mchehab> make DOCBOOKS=media_api.xml htmldocs 2>&1 | grep -v "element.*: validity error : ID .* already defined" [16:56] <mchehab> (media stuff) [16:57] <pinchartl> warning: failed to load external entity "/home/laurent/src/kernel/media.git/Documentation/DocBook/pixfmt-y16-be.xml" [16:57] <pinchartl> /home/laurent/src/kernel/media.git/Documentation/DocBook/pixfmt.xml:1513: parser error : Failure to process entity sub-y16-be [16:57] <pinchartl> &sub-y16-be; [16:57] <pinchartl> ^ [16:57] <pinchartl> /home/laurent/src/kernel/media.git/Documentation/DocBook/pixfmt.xml:1513: parser error : Entity 'sub-y16-be' not defined [16:57] <pinchartl> &sub-y16-be; [16:57] <mchehab> $ make htmldocs [16:57] <mchehab> GEN Documentation/DocBook//v4l2.xml [16:57] <mchehab> rm -rf Documentation/DocBook/index.html; echo '<h1>Linux Kernel HTML Documentation</h1>' >> Documentation/DocBook/index.html && echo '<h2>Kernel Version: 4.2.0-rc2</h2>' >> Documentation/DocBook/index.html && cat Documentation/DocBook/80211.html Documentation/DocBook/alsa-driver-api.html Documentation/DocBook/crypto-API.html Documentation/DocBook/debugobjects.html Documentation/DocBook/device-drivers.html Documentation/DocBook/deviceiobook.html Documentation/DocBook/drm.html Documentation/DocBook/filesystems.html Documentation/DocBook/gadget.html Documentation/DocBook/genericirq.html Documentation/DocBook/kernel-api.html Documentation/DocBook/kernel-hacking.html Documentation/DocBook/kernel-locking.html Documentation/DocBook/kgdb.html Documentation/DocBook/libata.html Documentation/DocBook/librs.html Documentation/DocBook/lsm.html Documentation/DocBook/media_api.html Documentation/DocBook/mtdnand.html Documentation/DocBook/networking.html Documentation/DocBook/rapidio.html Documentation/DocBook/regulator.html Documentation/DocBook/s390-drivers.html Documentation/DocBook/scsi.html Documentation/DocBook/sh.html Documentation/DocBook/tracepoint.html Documentation/DocBook/uio-howto.html Documentation/DocBook/usb.html Documentation/DocBook/w1.html Documentation/DocBook/writing-an-alsa-driver.html Documentation/DocBook/writing_musb_glue_layer.html Documentation/DocBook/writing_usb_driver.html Documentation/DocBook/z8530book.html >> Documentation/DocBook/index.html [16:58] * mchehab is using the upstream tree on the above [16:58] <mchehab> plus the patch I just submitted [16:58] <mchehab> --- a/Documentation/DocBook/media/dvb/intro.xml [16:58] <mchehab> +++ b/Documentation/DocBook/media/dvb/intro.xml [16:58] <mchehab> @@ -164,7 +164,7 @@ are called:</para> [16:58] <mchehab> from 0, and M enumerates the devices of each type within each [16:58] <mchehab> adapter, starting from 0, too. We will omit the “ [16:58] <mchehab> <constant>/dev/dvb/adapterN/</constant>” in the further discussion [16:58] <mchehab> -of these devices. [16:58] <mchehab> +of these devices.</para> [16:58] <mchehab> diff --git a/Documentation/DocBook/media/dvb/intro.xml b/Documentation/DocBook/media/dvb/intro.xml [16:58] <mchehab> index d30751338493..51db15648099 100644 [16:58] <mchehab> --- a/Documentation/DocBook/media/dvb/intro.xml [16:58] <mchehab> +++ b/Documentation/DocBook/media/dvb/intro.xml [16:58] <mchehab> @@ -167 +167 @@ adapter, starting from 0, too. We will omit the “ [16:58] <mchehab> -of these devices. [16:58] <mchehab> +of these devices.</para> [16:58] <pinchartl> weird [16:58] <pinchartl> unable to parse /home/laurent/src/kernel/media.git/Documentation/DocBook/media_api.xml [16:58] <mchehab> are you using it with O= parameter? [16:59] <pinchartl> no [16:59] <mchehab> weird [16:59] <pinchartl> just make htmldocs [16:59] <mchehab> perhaps some leftovers? [16:59] <mchehab> try make cleandocs [17:00] <pinchartl> https://paste.kde.org/pp9jqq12c [17:00] <mchehab> really weird [17:01] <mchehab> perhaps a broken xmlto toolchain [17:01] <pinchartl> let me cleandocs [17:01] <pinchartl> it helped, thanks [17:04] <pinchartl> looks like we're not processing any header [17:04] <pinchartl> neither MC nor V4L2 [17:04] <mchehab> yep [17:04] <pinchartl> it shouldn't be difficult to fix [17:07] <pinchartl> it's not a prerequisite for your patch series, but it would be nice to be able to test kerneldoc in the not too distant future [17:07] <pinchartl> I'll try to reply to your replies later today [17:08] <headless> reply to the replies and answer the answers :-) [17:08] <hverkuil> intro.xml is broken, there is a missing </para>. We never changed that, so it comes from upstream. [17:09] <hverkuil> noticed the same problem yesterday [17:09] <hverkuil> never mind. [17:09] <hverkuil> I see the patch. [17:09] <pinchartl> commit ed099f66dadd8bac93571fb28b05bdae066b39a2 [17:09] <pinchartl> Author: Masanari Iida <standby24x7@gmail.com> [17:09] <pinchartl> Date: Mon Jul 13 20:36:50 2015 -0300 [17:09] <pinchartl> [media] DocBook: Fix typo in intro.xml [17:09] <pinchartl> it has your SoB ;-) [17:14] <mchehab> pinchartl: adding things there are easy... [17:14] <mchehab> but one should do the hardwork of fixing the already broken things [17:15] <mchehab> http://pastebin.com/JcXsqcVH [17:15] <mchehab> just with core stuff [17:19] <pinchartl> that really shows we have never compiled it :-) [17:19] <mchehab> yep [17:19] <mchehab> patch enabling it sent to ML [17:20] <mchehab> won't apply until someone have time to fix things [17:21] <mchehab> Actually, just two errors: [17:21] <mchehab> Error(.//drivers/media/dvb-core/dvb_math.h:35): duplicate section name 'example' [17:21] <mchehab> Error(.//drivers/media/dvb-core/dvb_math.h:39): duplicate section name 'example' [17:22] <mchehab> easily fixable, it seems [17:26] <mchehab> still lots of: [17:26] <mchehab> .//include/media/videobuf2-memops.h - Document generation inconsistency [17:26] <mchehab> at the generated docbook [17:28] <pinchartl> as long as compilation doesn't break we can fix that as we go [17:30] <mchehab> int - callback function for use with vb2_thread [17:30] <mchehab> Synopsis [17:30] <mchehab> typedef int ( * vb2_thread_fnc); [17:30] <mchehab> Arguments [17:30] <mchehab> vb2_thread_fnc [17:30] <mchehab> -- undescribed -- [17:30] <mchehab> Description [17:30] <mchehab> This is called whenever a buffer is dequeued in the thread. [17:30] <mchehab> that's funny... [17:30] <mchehab> we just invented a function called "int" :) [17:31] <mchehab> somewhere in VB2 [17:33] <mchehab> pinchartl: I guess the best is to add for now just the stuff that minimally produces something useable... [17:33] <mchehab> fix then [17:34] <mchehab> and move to the other stuff that are just plain broken (even if compilation won't cause errors) [17:34] <mchehab> like this: http://pastebin.com/XP0s3WJr [17:35] <mchehab> still, lots of warnings to fix: http://pastebin.com/Ld916dFi [17:39] <mchehab> pinchartl, hverkuil: sent a version 2 of the patch enabling it [17:44] <pinchartl> mchehab: agreed [17:45] <pinchartl> it should also be in a clearly separated section of the docbook documentation [17:45] <pinchartl> as it documents the in-kernel API, not the userspace API [17:46] <mchehab> pinchartl: it is [17:47] <mchehab> I added it at the device-drivers section, just after Sound drivers [18:19] <shuah> mchehab: I haven't had a chance to review all the patches yet. It might be easier to review them with a use-case - is it possible to show how these interfaces re used [18:20] <shuah> btw - we can discuss this later in detail. I am in a meeting and have to head to the airport soon [18:20] *** shuah has quit IRC (Quit: shuah)