bparrot: I haven't had time yet to look at v5 for CAL. Sorry. Hopefully this Friday.
posciak: ping
hverkuil: pong
posciak: pong
pinchartl: did you finish the review of the MC series?
hverkuil: reopng
repong
hverkuil: Ping?
sailus_: pong
hverkuil: Heippa!
I was going to ask you about the baseline for your vb2 split patchset, but I found it in your repository already. :-)
yup. I was planning to make a pull request for that soon.
Another question --- so in order to allocate buffers while streaming, the user would do TRY_FMT() to the number of planes and their sizes and pass those to CREATE_BUF?
While it used to be just CREATE_BUF?
Is that the correct understanding of it?
Nobody requires the use of TRY_FMT, but if you want to be certain you are using valid values, then that's the right sequence.
Really not any different from what happens today.
For most drivers the only thing they care about is that the imagesize is larger or equal to the current format
format's imagesize
We don't have drivers that can handle buffers that are smaller and are smart enough to handle format changes on the fly.
at least, no such drivers are in the kernel.
Format changes aren't done on the fly, but that's entirely separate from creating new buffers.
The use case is really that sometimes you want to allocate buffers while streaming, and those buffers aren't necessarily for the format which is used on the device at the time for streaming.
TRY_FMT is needed for the application to be aware of the buffer size to allocate.
Looking at the changes, what's there for the queue_setup() callback to actually left do?
s/do/to do/
Nothing, as far as I can tell?
With  the possible exception of enforcing the minimum number of buffers.
minimum buffers/planes/size validation.
It has to fill that info in when called with REQBUFS.
Right.
But how does it know the minimum requirement if it has no access to format?
Other than that *configured* using SET_FMT.
S_FMT, I mean.
The user may wish to also allocate smaller buffers than what's configured.
Sorry. I need to leave the office.
I'll stay on the channel but might be back online later / tomorrow morning.