<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style> posciak: <u>pinchartl</u>: ping ***: _sic_ has quit IRC (Ping timeout: 260 seconds) <br> broonie has quit IRC (Remote host closed the connection) posciak: I'm confused by the way fields are being added to v4l2_pix_format. I understand we added the V4L2_CAP_EXT_PIX_FORMAT and V4L2_PIX_FMT_PRIV_MAGIC, but why is this not one-time? I mean, once we start differentiating between "old" and "new" struct v4l2_pix_format ABI, we can't keep adding new fields to the new one anymore either...? But we seem to be doing so... I'm trying to understand why is this ok/doesn't break <br> the ABI? ***: ndufresne is now known as stormer <br> stormer is now known as ndufresne <br> kaspter has quit IRC (Remote host closed the connection) <br> hackeron_ has quit IRC (Ping timeout: 260 seconds) <br> myself has quit IRC (Ping timeout: 260 seconds) <br> linkedinyou has quit IRC (Quit: linkedinyou) pinchartl: <u>posciak</u>: pong <br> do we keep adding new fields ? posciak: <u>pinchartl</u>: do you mean apart from your initial patch to add the magic and ext format? pinchartl: ok, now I remember <br> v4l2_pix_format isn't used directly in ioctls <br> it's embedded in v4l2_format <br> so we can extend it using the reserved fields of v4l2_format posciak: ahh <br> of course pinchartl: up to 200 bytes posciak: now all makes sense <br> thank you pinchartl: you're welcome posciak: although, I guess it still doesn't tell the application which fields it can use <br> if we add additional fields pinchartl: the spec now mandates applications to zero reserved fields <br> so a new field would need to consider a zero value as not used by applications posciak: yeah but it's an ABI <br> how do we know which fields to check? <br> for example, Hans added a new field later, xfer_func pinchartl: as long as the default value is 0 we're fine <br> if you add a new field <br> make sure that value == 0 keeps the current behaviour <br> if userspace doesn't set the field explicitly it will zero it <br> so the behaviour won't change posciak: I see ***: teob has left <br> zahari has quit IRC (Ping timeout: 245 seconds) <br> ezequielg has quit IRC (Ping timeout: 260 seconds) <br> benjiG has left <br> makomk has quit IRC (Quit: leaving) <br> julius has left "Leaving" <br> posciak has quit IRC (Ping timeout: 245 seconds) <br> DaRock has quit IRC (Remote host closed the connection) <br> awalls1 has left <br> WeaselSoup has quit IRC (Read error: Connection reset by peer)