hverkuil: This looks like a false alarm.
OK, that's happened before with smatch. Thanks for looking at this.
Meeting. Back in around ½ an hour.
Oh. The meeting will be in half an hour. :-)
hverkuil: Hi Hans, for ov9655 support in ov9650.c, must I keep compatibility with old style platform_data or can I drop that and switch all 9650 to devicetree ?
hverkuil: how can I test ov9650/52 to check for non-regression ?
No one is using struct ov9650_platform_data in the kernel. That said, we usually just keep the platform data part around if it was there from the beginning, it doesn't hurt. And perhaps someone uses it in an out-of-tree driver.
Actually, that's quite likely.
hverkuil: platform_data are used for reset/powerdown gpios
hverkuil: and I want it from DT now, so here I have 2 choices
hverkuil: either keep the current gpio code and transform DT data to platform_data so rest of code remains the same (not so clean)
hverkuil:  either I add a new gpio handling code based on DT
hverkuil: perhaps you could check ov9650.c, function ov965x_configure_gpios()
hfr: what I see driver do is the former, have a OF function to populate the platform data from DT to avoid code duplication
the code won't remain the same though, since when using gpios from DT, it's expected to use the GPIO descriptor-based API while the old platform code uses the integer-based one
so probably you would like to use gpio_desc() and change the ov965x_configure_gpios() function to use the new GPIO API even when using platform data
thanks Javier, I will change the driver this way so
hverkuil: Could you check the digital gain patches I posted recently?
http://www.spinics.net/lists/linux-media/msg116704.html
There's a driver that would use the new control...
looks good. Shall I pick them up for a pull request on Friday?
I have an OV sensor driver patch that depends on them.
Ah, and you want to make a pull request for that one.
I discussed with Mauro that I'd send a pull request with them.
I'll Ack then.
Thanks.
done
Shall we have a meeting at 3pm Finland time? (i.e. in an hour)
Works for me.