[07:08] <sailus> hverkuil: Huomenta!
[08:00] <sailus> hverkuil: I've just sent v10, there's no difference to the core stuff though.
[08:07] <hverkuil> sailus: thanks, I'll continue reviewing with v10.
[09:24] <Mason385> Hello everyone. I'm testing an IR RC driver, and I seem to be getting strange results for repeats. The scancode reported is 0x00, I expected this to be the scancode of the repeated key... ?
[09:25] <Mason385> 386.576816: event type EV_MSC(0x04): scancode = 0x4cb41  + event type EV_SYN(0x00).
[09:25] <Mason385> 386.627301: event type EV_MSC(0x04): scancode = 0x00 + event type EV_SYN(0x00).
[09:26] <Mason385> I think I see why this is happening:
[09:26] <Mason385> in rc-main.c, ir_do_keydown() only records the last_scancode when keycode != KEY_RESERVED
[09:26] <Mason385> and u32 keycode = rc_g_keycode_from_table(dev, scancode);
[09:27] <Mason385> but I think rc_g_keycode_from_table() always returns KEY_RESERVED
[09:52] <hverkuil> sailus: finished review. Those 'external refs' patches need more work, I had a very hard time understanding the code.
[10:33] <sailus> hverkuil: I think you're right, they need more documentation.
[10:33] <sailus> You don't always end up thinking that when you've written one of these functions. :-)
[12:39] <hverkuil> sailus: I kind of like doing these in-depth code reviews. Very educational for me.
[12:42] <hverkuil> It takes a lot of time, but it's definitely worth it for this core code.
[13:10] <hverkuil> sailus: this one from Niklas is still valid, right? https://patchwork.linuxtv.org/patch/42843/
[13:11] <hverkuil> The other three patches from Niklas's patch series are all superseded since the re-probe code has been removed, correct?
[13:11] <hverkuil> If that first patch is still valid, can you add it to the upcoming v11? It belongs in that patch series IMHO.
[13:20] <padovan> hverkuil, are you going to be at LPC this week?
[13:21] <hverkuil> no
[13:21] <hverkuil> I'll be at Kernel Recipes at the end of the month and at the ELCE next month.
[13:31] <padovan> okay, there is a chance a may go to ELCE, but I'm not counting on that
[13:37] <Mason385> hverkuil: you will be a speaker again at KR?
[13:37] <hverkuil> y
[13:41] <hverkuil> Mason385: I heard that KR was full in 3 1/2 hours after registration opened. So unless you're a speaker it's rather difficult to get in :-)
[13:41] <Mason385> hverkuil: I got a message that registration was open, and was registered within 10 minutes :-)
[13:44] <hverkuil> pinchartl: ah, you managed to get registered as well! Looking forward to meeting you!
[13:46] <hverkuil> I see quick a few familiar names in the attendees list. Nice.
[14:02] <Mason385> hverkuil: didn't you meet laurent last year? You were both speakers IIRC.
[14:05] <hverkuil> Of course, but I didn't expect him to be at KR this year.
[15:17] <sailus> hverkuil: Ping?
[15:29] <hverkuil> sailus: pong
[15:33] <sailus> hverkuil: I noticed someone had accidentally assigned me this:
[15:33] <sailus> https://patchwork.linuxtv.org/patch/42390/
[15:33] <sailus> I can put it in my tree if that's ok for you.
[15:34] <sailus> (Or something.)
[15:35] <hverkuil> Sure, no problem. Or you can assign it back to me. Up to you.
[15:48] <sailus> I'll pick it up then.
[15:48] <sailus> And send v11 likely tomorrow.
[16:00] *** benjiG has left