hverkuil: Huomenta!
hverkuil: I've just sent v10, there's no difference to the core stuff though.
sailus: thanks, I'll continue reviewing with v10.
Hello everyone. I'm testing an IR RC driver, and I seem to be getting strange results for repeats. The scancode reported is 0x00, I expected this to be the scancode of the repeated key... ?
386.576816: event type EV_MSC(0x04): scancode = 0x4cb41  + event type EV_SYN(0x00).
386.627301: event type EV_MSC(0x04): scancode = 0x00 + event type EV_SYN(0x00).
I think I see why this is happening:
in rc-main.c, ir_do_keydown() only records the last_scancode when keycode != KEY_RESERVED
and u32 keycode = rc_g_keycode_from_table(dev, scancode);
but I think rc_g_keycode_from_table() always returns KEY_RESERVED
sailus: finished review. Those 'external refs' patches need more work, I had a very hard time understanding the code.
hverkuil: I think you're right, they need more documentation.
You don't always end up thinking that when you've written one of these functions. :-)
sailus: I kind of like doing these in-depth code reviews. Very educational for me.
It takes a lot of time, but it's definitely worth it for this core code.
sailus: this one from Niklas is still valid, right? https://patchwork.linuxtv.org/patch/42843/
The other three patches from Niklas's patch series are all superseded since the re-probe code has been removed, correct?
If that first patch is still valid, can you add it to the upcoming v11? It belongs in that patch series IMHO.
hverkuil, are you going to be at LPC this week?
no
I'll be at Kernel Recipes at the end of the month and at the ELCE next month.
okay, there is a chance a may go to ELCE, but I'm not counting on that
hverkuil: you will be a speaker again at KR?
y
Mason385: I heard that KR was full in 3 1/2 hours after registration opened. So unless you're a speaker it's rather difficult to get in :-)
hverkuil: I got a message that registration was open, and was registered within 10 minutes :-)
pinchartl: ah, you managed to get registered as well! Looking forward to meeting you!
I see quick a few familiar names in the attendees list. Nice.
hverkuil: didn't you meet laurent last year? You were both speakers IIRC.
Of course, but I didn't expect him to be at KR this year.
hverkuil: Ping?
sailus: pong
hverkuil: I noticed someone had accidentally assigned me this:
https://patchwork.linuxtv.org/patch/42390/
I can put it in my tree if that's ok for you.
(Or something.)
Sure, no problem. Or you can assign it back to me. Up to you.
I'll pick it up then.
And send v11 likely tomorrow.