sailus: I now understand what the code does. One question: it would be much easier to explain if nprops would be limited to 1.
Do we need support for nprops > 1?
hverkuil: I think we waited too much and will resend some of the patches which adds HEVC format with comments addressed, do you have something against that?
you're talking about the HEVC patches from samsung?
hverkuil: yep
hverkuil: I'm talking for the basic ones, without controls
My suggestion: talk to the author of that series and coordinate with him. I have no problem with you taking over from him for the relevant parts.
I'm not sure why it takes so long for a new patch series. snawrocki: any idea what the status is with that?
hverkuil: OK, that is fair suggestion.
hi everyone
some new rc keymaps have been submitted, but the files have no copyright statement at the top. Does this matter?
https://patchwork.linuxtv.org/patch/45021/ and https://patchwork.linuxtv.org/patch/45022/
syoung: I'd point it out to them. Regardless of whether it is needed or not, it is good practice to put it in. If nothing else it is useful advertising :-) I think they just forgot.
hverkuil: ok, thanks :)
hverkuil, svarbanov: I didn't hear from Smitha, it seems she can't spent more time on that series, last time she said she was busy with other project. I don't want to nag her any more and I can't carry on now with this series myself either. svarbanov, I think you can go ahead, I'd just drop her an e-mail that you are continuing the work.
snawrocki: ok, thanks for the update!
svarbanov: just go wild! :-)
hverkuil: Hallo!
sailus: hi
Apologies for not being around this morning.
no problem.
On nprops --- as I mentioned, it'd make sense to move this function elsewhere. It could be used for parsing graphs, too.
So there would be just a single implementation of it.
Anyway, I now understand the code.
And what do you think about it? :-)
A major part of the problem was simply a lack of experience with ACPI and how to parse the examples.
The DT equivalents helped a lot.
Yes, I'd say the learning curve is somewhat steeper than with DT.
How to explain what the function does is still an open question.
Hmm.
If this function is moved to drivers/acpi (that was the proposal, right?) then it might be easier to write the comment since the reviewers there are more familiar with acpi (I hope!) then we are.
Yes, that's what I thought.
A specific function for parsing graphs exists there; it's just less generic than this one.
If it remains in drivers/media, then the best option would be to use the ACPI example with nprops = 2 that you mailed, together with the equivalent as a DT structure.
That helped a lot in understanding the code. Without it I was lost.
Ok. I'll add that to the commit message.
I really do think you need an example with nprops > 1, since that was the case I had specific problems with.
Ok.
I think adding it to the code would be better (assuming it stays in drivers/media).
Then the existing example would be fine, wouldn't it?
Yes, it is a large example, but it's worth it.
The \_SB.PCI0.I2C2 example should be fine.
To be honest, it's a long time ago since I had so many problems understanding a piece of code :-)
I'm not sure if I should take that as a compliment or not. X-)
:-)
Which example did you actually mean?
The current patch has an example using nprops == 1.
Whereas the graph example has nprops =0 2.
nprops == 2.
graph example
Ah. I think I misunderstood then what you meant first. I'll send an update to the patch, adding the graph example to the function comment.
As it wouldn't make much point in having a different example in the commit message.
hverkuil: Sent.
sailus: the description is really impossible to understand :-)
to start with
"Then under that fwnode, @nprops times, for each property in @props,"
it's not @nprops time for each property in @props
that would be @nprops*@nprops times
I'd write it "Then under that fwnode, for each property in @props, ..."
but even with that, it's just too complicated
couldn't you write a description that someone could understand without requiring a half hour private discussion with you ?