| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| paulk-leonov | hverkuil, hi, I've been experiencing a NULL pointer dereference on vb2_m2m_request_queue (on reqv15) when playing videos in Kodi
here's a trace: http://leonov.paulk.fr/collins/~paulk/paste/index.php?paste=1cfe34ef8697e2c80706a8f2582c7b99&raw=true I've seen it twice in 24h hverkuil, feel free to let me know if I should reply to the list about it :) | [07:01] |
| ........ (idle for 39mn) | ||
| mripard | paulk-leonov: it's the issue I was trying to debug last week | [07:41] |
| paulk-leonov | heh | [07:42] |
| mripard | the issue seems to be that there's a stale media_request_object in the list, with the value that is *always* 0xf0
switching to list_for_each_entry_safe seems to mitigate the issue, but I'm not really sure what the root cause is | [07:42] |
| paulk-leonov | ah right, there was that
not sure I'll have time to investigate in-depth | [07:45] |
| hverkuil | mripard: paulk-leonov: are you guys using the latest reqv15? I.e. you should have the three additional fixes from 2 weeks ago: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=reqv15
You probably have those, but I'm just checking. | [07:51] |
| paulk-leonov | hverkuil, yes, we were careful to include them
our tree is at: https://github.com/free-electrons/linux-cedrus/commits/cedrus/4.18/requests-api-v15 | [07:51] |
| hverkuil | There is also a debugfs node (/sys/kernel/debug/media/media0/requests if memory serves) that shows the number of active requests and request objects.
If nothing is streaming, then those should be 0. If not, then requests or objects are being leaked. paulk-leonov: does this happen during streaming, or at the start or end of streaming? | [07:53] |
| paulk-leonov | hverkuil, during streaming
yes I'll check debugfs next time it happens :) | [08:08] |
| ........... (idle for 54mn) | ||
| hverkuil | mripard: you are on the right track: submitting a new request involves walking the list of objects, but if at the same time a buffer is finished and is unbound, then the walk will fail.
I'll look into this. | [09:02] |
| mripard: paulk-leonov: BTW: each request has just one capture and one output buffer, I assume?
does your application first add buffers and then controls to the request, or is it first controls, then buffers? | [09:12] | |
| paulk-leonov | hverkuil, yes, we have one pair of buffers per request only
hverkuil, let me check on the order hverkuil, controls first, then qbuf it's at: https://github.com/free-electrons/cedrus-frame-test/blob/master/v4l2.c#L443 | [09:15] |
| hverkuil, thanks for looking into it :) | [09:23] | |
| hverkuil | mripard: paulk-leonov: mailed a patch (only compile tested!) that I think should solve this problem. | [09:37] |
| paulk-leonov | hverkuil, awesome! I'll try it as soon as I get the chance | [09:38] |
| .............................................. (idle for 3h46mn) | ||
| ezequielg | hverkuil: what do you think about dropping the unused macros from the mem2mem mc topology series?
I am about to submit v3, and I am not sure I want to include those. | [13:24] |
| hverkuil | ezequielg: https://www.mail-archive.com/linux-media@vger.kernel.org/msg133007.html | [13:27] |
| cristian_c | hi
I've built and installed easycap smi driver (kernel module) I've got driver sources from github repository (via AUR on archlinux, and via github in ubuntu) I've also loaded firmware too (in addition to driver loading) so, I've started vlc and I've connected easycap dongle to input source and to usb port if I look at dmesg output I see a large amount of messages (all them almost the same message) 'smi2021 Skip broken frame N line, but need 240 in current 480 height' vlc screen is always blank, btw so, how could I solve this issue, in order to grab video from the device? any ideas? | [13:33] |
| hverkuil | test first with v4l2-ctl: does v4l2-ctl --stream-mmap work without errors?
Where is the driver source code, BTW? | [13:40] |
| cristian_c | :O
yes, I link url immediately | [13:40] |
| hverkuil | Or use qv4l2. We know those two apps work. | [13:41] |
| ezequielg | hverkuil: yes, i read that :) but i am suggesting not even including that as a separate patch. | [13:43] |
| hverkuil | Sure, it's not needed for vim2m.
But we'll need it very soon for 'real' HW codecs. | [13:43] |
| cristian_c | hverkuil: https://github.com/Manouchehri/smi2021 | [13:44] |
| ezequielg | hverkuil: OK, thanks. | [13:44] |
| cristian_c | aur package is provided by its own github repo (that I've got for ubuntu)
yeqh, I can try both v4l2-ctl and qv4l2 | [13:45] |
| hverkuil | I'm not sure why this driver isn't in the kernel. It isn't bad code. | [13:47] |
| cristian_c | yeah, somebody says it's compliant with gpl | [13:48] |
| hverkuil | although copy_video_block() has some horrible code. | [13:48] |
| cristian_c | but, I think nobody cares
hverkuil: some years ago, I tried this grabber and it worked on an older version of ubuntu I think 12.04 or 14.04, but system crashed (with nouveau drivers) that pc broke itslefmafter some months and I didn't try anymore (sorry for the details) | [13:48] |
| hverkuil | If someone would care, then it wouldn't be too much work to get this in mainline kernel. | [13:51] |
| cristian_c | I'd like make itmto work (in order to bring vhs videos to disk)
btw, now I try the tools | [13:52] |
| hverkuil: v4l2-ctl prints 15.02 fps lines in its log
but I don't know ifmit has selected video0 or video1 ok, I'm trying v4l2 test bench | [13:59] | |
| hverkuil | default for v4l2-ctl is video0. You can change that with v4l2-ctl -d /dev/video1 (or -d1)
-D option shows driver info,. | [14:02] |
| cristian_c | qv4l2 doesn't have a select menu for device | [14:03] |
| hverkuil | File Open | [14:03] |
| cristian_c | now, I try v4l2-ctl | [14:03] |
| hverkuil | File Menu, then Open Device | [14:04] |
| cristian_c | yeah, but in /dev I don't see video0 or video1 | [14:04] |
| hverkuil | then nothing will work and the driver isn't loaded or the usb device isn't connected.
Oh, in the file dialog! | [14:04] |
| cristian_c | I mean, File->Open Device -> Select v4l device | [14:04] |
| hverkuil | Are you of group video? (run 'id')
I think you can't see them unless you are in that group. | [14:05] |
| cristian_c | you0re right, I'm nost member of 'video' group :O
*not I make logout and login again oddly, v4l2 open filemdialog doesn't show video0 or video1 in /dev directory though v4l2 main window shows /dev/video0 in Device *qv4l2 | [14:06] |
| hverkuil | Try 'qv4l2 -d1' | [14:12] |
| cristian_c | yeah, I mean about that
sorry ok, sorry v4l2-ctl hangs when I use -d /dev/video1 parameter instead, qv4l2 -d1mshow video1 info properly thabks *thanks :O I didn't know grabber used NTSC as 'TV Standard' frame width 720 , frame height 480 | [14:12] |
| hverkuil | Is the source PAL? | [14:15] |
| cristian_c | I livemin europe, my vhs is a recording from a europ tv, I think pal | [14:16] |
| hverkuil | Switch to PAL in qv4l2. Or use 'v4l2-ctl -s pal'.
That's v4l2-ctl -d1 -s pal of course | [14:17] |
| cristian_c | pal has changed to 720 width and 576 height
ntsc used 720x480 ok, if I type v4l2-ctl -d /dev/video1 --streams-mmap it hangs, instead if I type v4l2-ctl -d /dev/video1, it returns the prompt immediately now, I try -s parameter hverkuil: v4l2-ctl -d1 -s pal returns: Standard set to 000000ff in qv4l2 pal-60 is 720x480 | [14:18] |
| hverkuil | don't use pal-60, just regular pal | [14:35] |
| cristian_c | yeah, I've tried many tv standards, included simply 'pal'
I've lookedmat dmesg dmesg output is different than when I use vlc | [14:36] |
| learningc | What is exactly the remote controller api? | [14:37] |
| cristian_c | two lines 'queue_setup: buffer count 4. each N bytes' | [14:38] |
| hverkuil | learningc: https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/rc/remote_controllers.html | [14:38] |
| cristian_c | then, 'allocating urbs...' and hen '16 urbs of 10240 bytes, allocated'
then 'killing 16 urbs', 'all urbs killed' , 'clear_queue called' | [14:39] |
| learningc | Are the remote controllers API only for IR type controllers? What about radio controllers? | [14:41] |
| cristian_c | and four lines 'buffer [address/n] aborted' where n is 1,2,3,0
finally, 'returning from clear_queue' and 'streaming stopped' | [14:41] |
| hverkuil | learningc: I don't think it is restricted to IR. Whether there are already radio controllers in the kernel I have no idea.
You can ask on the linux-media mailinglist, Sean Young is the RC maintainer. cristian_c: sorry, have to leave. | [14:42] |
| cristian_c | thanks for the help | [14:44] |
| ..... (idle for 24mn) | ||
| *** | benjiG has left | [15:08] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |