| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| tfiga | mjourdan: have you tried looking at V4L2 ioctl debug logs? (the ones you enable with /sys/class/video4linux/videoX/{dev_,}debug
mjourdan: also, are you using the native v4l2 support or via a custom ffmpeg? | [08:05] |
| .............. (idle for 1h5mn) | ||
| mjourdan | tfiga: using the native v4l2 support. Upon seeking, the last log from v4l2_video_decode_accelerator.cc is ResetDoneTask(), and then nothing. Visually it's just an endless loading circle over the video. I'll try with V4L2 ioctl debugging! | [09:10] |
| hverkuil | mjourdan: https://hverkuil.home.xs4all.nl/spec/kapi/v4l2-dev.html#video-device-debugging | [09:14] |
| mjourdan | hverkuil: thanks :) | [09:17] |
| ...... (idle for 27mn) | ||
| tfiga: Ah.. looks like all but one capture buffers get queued back after streamoffs/streamons, but I need all of them.. I'm guessing the one not queued is the still frame displayed in the video while waiting for the seek to go through ? | [09:44] | |
| ........ (idle for 35mn) | ||
| hverkuil | paulk-leonov: ping | [10:19] |
| paulk-leonov | hverkuil, pong | [10:20] |
| hverkuil | Hi Paul, I wonder if you could do a quick cedrus & v4l2-compliance test for me.
I committed my Request API compliance tests yesterday, but I'd like to have it tested with the cedrus driver as well. I know the test will fail, but I'd like to know where it will fail. In order to make the test work correctly more work will be needed. | [10:20] |
| paulk-leonov | hverkuil, sure thing, I will give it a spin later today or tomorrow | [10:22] |
| hverkuil | but that will be developed first for vicodec by an Outreachy intern when she starts work on this in December. | [10:22] |
| tfiga | mjourdan: that's possible
mjourdan: do you need all or you just need a fixed number? if the latter, maybe you need to return a higher value in MIN_BUFFERS_FOR_CAPTURE? | [10:27] |
| mjourdan | tfiga: All of them sadly. The firmware wants the full list at init and is free to write to any buffer it wants to at any time. so I have min_buffers_for_capture set to the amount of buffers allocated. | [10:29] |
| hverkuil | tfiga: good review of the rockchip jpeg encoder. Decided to drop the pull request and wait for your comments to be fixed.
tfiga: I know all about backlog. After spending almost two weeks full time on this I am now (mostly) on top of things again. | [10:31] |
| tfiga | hverkuil: we have a no meetings week this week and so it's a chance for me to actually spend the time on reviewing
mjourdan: why do you need to re-register them after streamoff? I suppose there is no reqbufs in the meantime? | [10:34] |
| mjourdan | tfiga: because both streamoffs trigger a poweroff of the IP :P | [10:37] |
| tfiga | mjourdan: okay, something to fix then :)
mjourdan: also, it's MMAP mode I assume? you know all the buffers even if they're not queued to oyu given the restrictions, DMABUF mode wouldn't work (which is actually not so rare for statefull decoders) | [10:37] |
| mjourdan | tfiga: I guess I do but I can't risk the firmware writing to buffers that are not queued in yet. And yeah it's MMAP | [10:47] |
| ....... (idle for 30mn) | ||
| tfiga | mjourdan: yeah, the buffers that are not queued shouldn't be written to | [11:17] |
| mjourdan | tfiga: oh I mistook min_buffers_for_capture with queue->min_buffers_needed. Yeah I'm trying right now to raise MIN_BUFFERS_FOR_CAPTURE | [11:22] |
| tfiga: alright, fixed it by increasing MIN_BUFFERS_FOR_CATPURE (+ a few fixes related to that), and always sending a src change event even if the resolution/dpbsize remain the same
It's overall a bit hacky though, esp. with the part where I now set min_buffers_needed to (dst_bufs_num-1).. probably won't go into the PR | [11:32] | |
| ezequielg | hverkuil: I sent a revert for the bindings doc. That is why the bindings doc patch is on that series. | [11:40] |
| hverkuil | ezequielg: Ah, and that revert probably hasn't been pulled in yet. Is it even in a pull request? Can you check patchwork? | [11:41] |
| ezequielg | let me check
no, mchehab hasn't picked the revert patch yet. | [11:47] |
| hverkuil: the thing is, the vpu dt bindings doc will land in v4.20, unless it's reverted.
hverkuil: so I thought it was better to have that reverted in v4.20, until the driver is accepted. | [11:58] | |
| hverkuil | Ah, it wasn't picked up by anyone.
I'll make a pull request for 4.20 for it. | [11:59] |
| ezequielg | thanks! | [12:00] |
| hverkuil | done | [12:02] |
| .... (idle for 15mn) | ||
| tfiga | mjourdan: the resolution change is an interesting trick indeed, although you might need the patch to allow REQBUFS(0) with exported DMA-bufs in use | [12:17] |
| .... (idle for 15mn) | ||
| mjourdan | tfiga: already patched that a few days ago :D . I wouldn't have been able to even play something without it. | [12:32] |
| tfiga | mjourdan: okay :) | [12:40] |
| .................................................... (idle for 4h18mn) | ||
| *** | benjiG has left | [16:58] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |