<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>
hverkuil: <u>mchehab</u>: can you look at https://patchwork.linuxtv.org/patch/56441/ (and hopefully merge it): it would fix a compat build issue with timekeeping.h. I could patch around it in media_build, but I think it is perfectly reasonably to have the source include ktime.h instead.
***: lvrp16 has quit IRC (Ping timeout: 252 seconds)
<br> [LOGGER] has quit IRC (Ping timeout: 252 seconds)
<br> prabhakarlad has quit IRC (Ping timeout: 248 seconds)
<br> gouchi has quit IRC (Remote host closed the connection)
<br> kaspter has quit IRC (Read error: Connection reset by peer)
<br> learning has quit IRC (Ping timeout: 272 seconds)
<br> mszyprow has quit IRC (Ping timeout: 272 seconds)
<br> Darkmatter66 has quit IRC (Ping timeout: 246 seconds)
mchehab: @all: I'm going to work on patchwork migration at linuxtv.org. e-mail and patchwork will be unavailable for a while
***: bparrot has quit IRC (Remote host closed the connection)
<br> amerel has quit IRC (Remote host closed the connection)
mchehab: @all: patchwork migrated to version 2.1.2
***: lucaceresoli has quit IRC (Quit: Leaving)
sailus: Nice!
<br> How difficult was it to carry on the existing database?
***: pH5 has quit IRC (Quit: bye)
<br> BenG83_ has quit IRC (Ping timeout: 264 seconds)
mchehab: <u>sailus</u>: a collegue of Hans come up with an script to convert
<br> basically, the script did some things like dropping and recreating the database, as there were format changes also inside MySQL (charset issues)
<br> it seems that a few old patches were not imported yet
<br> s/yet/well
<br> <u>like</u>: https://patchwork.linuxtv.org/patch/35285/
<br> (no commit message - can't change its status)
b-rad: detected my series ok
mchehab: yes, that's nice!
b-rad: the color scheme is almost incompatible with my eyes though lol
mchehab: I tried to keep it as much as possible close to the old color schema
b-rad: the bright blue in the combo boxes is pretty much invisible to me
mchehab: probably related to monitor settings... here it shows fine
<br> feel free to propose some other color
b-rad: just more contrast
mchehab: (originally it was white on a grey box - with was *unreadeable*)
b-rad: my 4k display is calibrated well, but bright blue on black/dark grey is not too little contrast for me
mchehab: (light light gray)
<br> this is easily changeable
b-rad: :)
<br> btw, could you review the v4 4/4 email i just sent to the list addressing some of shawns concerns
mchehab: just give me the name of the color you want from: https://www.w3schools.com/colors/colors_names.asp
b-rad: k, about to leave for weekend, will do next week
<br> the question is just about whether or not le16_to_cpu is required for a constant
mchehab: never used it on a constant
b-rad: is theres no problem with the v5 series i'll make pull req soon, the branch is in my tree
<br> yeh constants are interpreted by compiler for correctness, so there's no need, that's what I thought
mchehab: it doesn't make much sense le16_to_cpu(some_constant)
<br> some_constant will already be at CPU endiannes
<br> it would make sense cpu_to_le16()
<br> it this is the case
<br> yeah, the compiler will always use CPU endiannes
<br> hdw->usb_dev->descriptor.idVendor == 0x2040
<br> we do those things like:
b-rad: yes those are the bits
mchehab: we don't use the endiannes macro at the constant side... we use it at the ID side
<br> drivers/media/usb/dvb-usb/dibusb-mc-common.c: if (le16_to_cpu(adap->dev->udev->descriptor.idVendor) == USB_VID_LITEON &&
b-rad: ok, sounds good. I'll fire off v6 before i head out
mchehab: btw, this driver is doing it wrong :-p
<br> drivers/media/usb/gspca/nw80x.c: } else if (id->idVendor == 0x06a5 && id->idProduct == 0xd800) {
b-rad: i figured if it was simple equivalence and not positional the check would pass
<br> do not have my mips board handy to test on though
<br> i noticed similarly incorrect checks in other spots
mchehab: yeah, almost nobody tests it with LE... that's likely why we see this some places
b-rad: sent up v6, i'll give sean a chance to review and make pull request probably monday
sailus: <u>mchehab</u>: It'd be nice to upstream the script so that others could use it. Albeit... there could be few patchwork 1.x instances left anyway.
mchehab: <u>sailus</u>: the script was designed for us only
<br> one of the issues we had is that there was some patches on our tree that were not at upstream
<br> in thesis, ./manage.py migrate should do the migration
<br> well, there were two other issues too: one with UTF-8 x Latin-1 (patchwork before 1.x were using Latin) at MySQL DB
<br> and another one related to the engine we used inside the DB
<br> so, I don't think the script would help other projects
<br> (anyway, I can't share it myself, as I didn't authored it)
sailus: Ack. I was just wondering if it could have been useful.
shuah: mchehab, hverkuil: do you plan to get this fix in https://patchwork.kernel.org/patch/10949571/
<br> It fixes 3 syzbot bugs
mchehab: <u>shuah</u>: I guess I merged it those days
shuah: I don't see it in 5.2-rc2 though
mchehab: I merged this week, I guess
shuah: Great thanks
mchehab: also, there's no c/c stable... it went to the main branch
<br> so, try checking it at linux-next
shuah: Okay - it will need to tagged for stable.
<br> Let me find the mainline commit - I can update syzbot reports with it
mchehab: then someone needs to re-send it again against my fixes branch
<br> If I applied there, I mean... can't check right now
<br> my server is not turned on and I'm fixing some things on patchwork
***: pinchartl has quit IRC (Ping timeout: 272 seconds)