sailus: pinchartl: thansk for review if we create an helper to register controls, the argument that setting up an integer menu control for drivers is a bit more work is now moot so I would actually go for a (menu control + helper) sailus: pinchartl: in the DT bindings, one seems to want to remove "camera" from "camera device", the other wants "camera sensor" in place of "device".. should we make the property camera specific, or stay generic, as it could apply to lenses and flash devices too ? X-) Let's wait for pinchartl to wake up. :) It is certainly possible to start with cameras and make the property more generic later on. mchehab: syoung: b-rad: (or other dvb specialists) please note this patch: https://patchwork.linuxtv.org/patch/58184/ I think that driver has been broken for over a year. Does anyone have that HW? Have there been bug reports about this device? I *might* have one device with gl861, but crope has for sure better to ping him at #linuxtv hverkuil: yeah, that sounds broken... it seems that this new memcpy() is used only on some ISDB cards as this was added by Akihiro Friio White ISDB-T receiver I don't have such devices here it won't hurt pinging Akihiro for his ack, but for me the fix is brain-dead s/brain-dead/nobrain/ ezequielg: v6 looks good. If there are no more comments, then I'll make a PR for it tomorrow. sailus: Hi Sakari, you there? hverkuil: sounds good :-) hverkuil: btw, the vivid race condition sounds familiar. we talked about drivers taking locks before. I wish we could clean that and avoid any drivers from doing that. I think I lack anything using that driver mchehab jmondi: Yes. sailus: are you happy with Hans and Laurent conclusions? using an integer control, and define the location as the "camera location" to be expanded to "flash location" eventually ? I've just seen you have replied pinchartl: Hi Laurent as you said, this way is faster for the connector discussion ^^ I'm fine with starting with starting with "camera location", with an integer control. sailus: thanks ping hverkuil, i just mailed out a patch related to your recent device_caps mismatch warning. I think it should sort out cx231xx