ribalda: Huomenta!
sailus: I just want to understand what is the purpose of COMPOSE_DEFAULT on v4l2_dev , and why it is needed there and not in v4l2_subdev
What would be its meaning on a sub-device?
mainly to help the application to set the default configuration. as in  v4l2_dev
(default, meaning maximum of valid pixes with a reasonable geometry)
On video devices it's the size of the memory buffer where composition is done (if there is a memory buffer).
ie: 1280x720 instead of 1284*723
On sub-devices there generally is no memory buffer.
Would it be different from BOUNDS?
bounds includes the black pixels
Ah, I see what you mean now.
I think.
Or not.
But on compose there's no such difference.
The black pixels are there in any case if they haven't been cropped.
and sorry to ask again, but what is the difference with v4l2_dev. Why do we need there compose_default?
I remember the target was originally added for some Samsung devices.
The documentation mentions the default values, but it's unclear to me whether this directly translates to *_DEFAULT targets.
AFAIR that wasn't the case.
Since those targets were not allowed for sub-devices.
I guess we could allow the COMPOSE_DEFAULT for sub-devices, too, but I can't think of a case where it'd be different from BOUNDS.
So it's not really useful as such.
And in general interfaces should be useful to be added.
sailus: thanks a lot! i will resend the patch
sailus: sorry about that
and thanks for catching it up
vbn: ping
hverkuil: pong