ezequielg: Sure.
Are you around now?
sailus: I'm around now :-)
ezequielg: Good. :-)
I'd rather like to get rid of the v4l2_async_notifier_parse_fwnode*() functions than add more users.
There's no need for these functions anymore.
can you explain a bit more: what's wrong with them and what's the replacement?
These make a number of assumptions on how the endpoints are parsed, and the whole parsing in drivers get a lot more complicated than it needs to be.
The current approach is to help drivers to parse the endpoints instead of trying to do it for drivers.
Please see e.g. drivers/media/pci/intel/ipu3/ipu3-cio2.c .
Also the omap3isp is a fine example, although somewhat more complicated as different ports have different properties there.
One major problem with v4l2_async_notifier_parse_fwnode*() is that you can't meaningfully use any defaults the DT bindings may define.
sounds good!
sailus: don't you think it's too much of a nitpick to ask people to add/remove empty lines ? ;-)
Not necessarily. Arranging the usual bits in functions in a consistent manner helps readability.
fair enough-ish.
:-)
one thing that we need to double check for this driver is the bindings.
because modelling the rpi v2 camera module is not the same as modelling the imx219.
regulator-wise specially.