| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | ajacla has left | [08:01] |
| ...... (idle for 27mn) | ||
| narmstrong | hverkuil: sorry for the delay of the answer to "all firmwares required for this are in linux-firmware, right?" yes, mjourdan pushed everything and it has been merged into linux-firmware
hverkuil: I'm fixing the sparse/smatch issues now | [08:28] |
| hverkuil | narmstrong: thanks! | [08:33] |
| ........... (idle for 54mn) | ||
| paulk-leonov: in reply to yesterday's question: just set the read-only control with v4l2_ctrl_s_ctrl (or one of the variants of that function) before calling v4l2_ctrl_request_complete. | [09:27] | |
| paulk-leonov | hverkuil: okay so if I need to do this after the encode is done, v4l2_ctrl_request_complete needs to be called late
the downside is that it can't run in atomic context hverkuil: also it seems that I found a bug, but not sure my fix is correct v4l2_ctrl_request_complete will copy p_cur to ref->p_req but v4l2_g_ext_ctrls_common will only call req_to_user if ref->req is set | [09:39] |
| hverkuil | To be precise, it has to be called between the v4l2_ctrl_request_setup and v4l2_ctrl_request_complete. | [09:40] |
| paulk-leonov | right
so the issue is that ref->req is not always set (not if the control wasn't set through s_ext_ctrl earlier) and even though v4l2_ctrl_request_complete will copy to p_req, v4l2_g_ext_ctrls_common won't pick it up and copy p_cur to p_user instead | [09:40] |
| hverkuil | Let me dig into that. | [09:42] |
| paulk-leonov | my fix is to set ref->req = ref in v4l2_g_ext_ctrls_common
which works but I'm not 100% sure it follows the general logic you had in mind | [09:42] |
| ...... (idle for 27mn) | ||
| *** | Proika has left | [10:10] |
| hverkuil | paulk-leonov: how do you set the read-only control? Do you use v4l2_ctrl_s_ctrl()? | [10:10] |
| *** | iglala has left | [10:11] |
| paulk-leonov | hverkuil: ah I must admit that I've just retrieving the struct v4l2_ctrl in the driver and changing its p_cur, a bit like we do to read it
is there an equivalent of v4l2_ctrl_s_ctrl for compound controls? | [10:13] |
| hverkuil | We'd need something like that. There is v4l2_ctrl_s_ctrl_area, but we probably need something a bit more generic.
but I don't actually understand why this fails. If ref->req == NULL, then v4l2_ctrl_request_complete() falls back to ptr_to_ptr(ctrl, ctrl->p_cur, ref->p_req);, which means that the current control's value is copied to the request. Isn't that what you want? | [10:14] |
| paulk-leonov | hverkuil: yes, the copy part is correct
hverkuil: the issue is in v4l2_g_ext_ctrls_common where req_to_user is only called if ref->req != NULL v4l2_ctrl_request_complete doesn't set ref->req | [10:22] |
| hverkuil | paulk-leonov: posted patch to fix this. Can you test it? | [10:33] |
| paulk-leonov | hverkuil: thanks!
I definitely did the very same thing and it solved the issue | [10:34] |
| hverkuil | Well, you set it in v4l2_g_ext_ctrls_common(), I set it in the complete function. So please double check and post a Tested-by if it works. I agree, it should end up being the same things, but I prefer to be thorough for these core frameworks.
I'm also working on better support to set compound controls. | [10:35] |
| paulk-leonov | hverkuil: ah sorry I was mistaken earlier, I did not set it in v4l2_g_ext_ctrls_common in fact, but also in v4l2_ctrl_request_complete as you did :) | [10:47] |
| .................................................... (idle for 4h16mn) | ||
| *** | benjiG has left | [15:03] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |