hverkuil, about compound controls, how it is supposed to be used from v4l2_ctrl_ops.s_ctrl? Currently I do - struct foo * foo = ctrl->p_new.p; Should we have some helper to extract the new value of the control?
svarbanov: Inside s_ctrl it is safe (and in fact correct) to use ctrl->p_new.p. Although you wouldn't use p, you would use the correct p_foo from union v4l2_ctrl_ptr.
hverkuil, ok, thanks for the clarification. More when I submit the patches.
hverkuil, sorry one more thing, what if my compound control doesn't need the last argument "const union v4l2_ctrl_ptr p_def" unfortunately it cannot be NULL.
and I have to give something
svarbanov: last argument to which function?
hverkuil, sorry to v4l2_ctrl_new_std_compound()
you pass v4l2_ctrl_ptr_create(NULL) as argument.
hverkuil, yes, the question is - is it allowed to pass v4l2_ctrl_ptr_create(NULL)
Yes
That means that the initial value of the compound control is all 0.
hverkuil, ahh I see now, thanks!
n/p
Posted a patch to clarify v4l2_ctrl_new_std_compound.