[00:17] *** padovan has quit IRC (Quit: Ping timeout (120 seconds)) [04:28] <tfiga> pinchartl: sailus: I just saw https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/media/i2c/imx219.c?h=next-20210514&id=dd90caa0111e178b52b21e56364bc2244a3973b3 and am wondering what it is actually doing [04:29] <tfiga> I might be misreading something, but to me it looks like runtime PM put is now called twice in resume [04:29] <tfiga> in the error path [04:34] <pinchartl> where's the second call ? [04:34] <pinchartl> (or the first one :-)) [04:48] <tfiga> one is in the error path of imx219_start_streaming() [04:48] <tfiga> and then another in the error path of imx219_resume() [04:54] <pinchartl> yes that looks wrong [04:55] <pinchartl> imx219_stop_streaming() shouldn't be called in imx219_resume() [04:56] <tfiga> on the other hand, I don't see what was wrong in the original code [05:25] *** harrow has quit IRC (Quit: Leaving) [14:06] *** b-rad has quit IRC (Ping timeout: 252 seconds)