<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style> ***: lyakh_ has joined #linux-media <br> lyakh has quit IRC (Ping timeout: 480 seconds) <br> NiksDev has joined #linux-media <br> NiksDev has quit IRC (Remote host closed the connection) <br> NiksDev has joined #linux-media <br> lyakh_ is now known as lyakh <br> jm_h has joined #linux-media <br> NiksDev2 has joined #linux-media <br> fleebs has joined #linux-media <br> ao2 has joined #linux-media <br> andrey-konovalov has joined #linux-media <br> robertfoss has quit IRC (Quit: WeeChat 2.6) <br> GBenji has joined #linux-media hverkuil: <u>jmondi</u>: ping ***: svarbanov has joined #linux-media jmondi: <u>hverkuil</u>: pong <br> good morning Hans hverkuil: <u>jmondi</u>: good morning! jmondi: how are you doing ? I suspect you're pinging me for the subdev init() op ? hverkuil: I saw your request to review the de-deprecate init patch (usually faster to ping here for a review). <br> I have a question (probably asked it in the past as well): the MAX9271 and the RDACM20/21: are those two always combined on the same chip? Can RDACM20/21 be used without the MAX9271? jmondi: sure, but so long time has passed than pinging you out of the blue without context seemed a bit useless :) hverkuil: just add a link to the patch, that's all the context I need :-) jmondi: RDAM20/21 are camera modules, they embed an image sensor (ov13565 and ov13640 respectively) with a GMSL serializer, plus some other chips like an MCU or a flash <br> so RDACM20/21 by definition, implies a MAX9271 serializer is used hverkuil: To be 100% clear: the MAX9271 is on those camera modules, right? jmondi: yes, embedded in the same package <br> just as an example they look like this <br> https://manualzz.com/doc/35585725/minicube-camera-platform hverkuil: OK, great. ***: sukbeom has quit IRC (Ping timeout: 480 seconds) hverkuil: Another question: why was the choice made to create separate RDACM20/21 drivers instead of e.g. an ov13565 driver? <br> Background: <br> I'm trying to figure out whether this 'init' sequence is something that is highly custom to this driver, or if it is something that should be more generic. jmondi: looking at the schematics it seems the camera module embedds two pcb, one for power and the other one with the imaging components... <br> sorry, still on the previous question :) <br> going forward I think it might make sense to break out the sensor drivers, and as Mauro sugested tranform the max9271 driver into a proper subdev driver <br> but the image sensor programming phase is in those camera modules performed by an on board MCU or loaded from a flash unit <br> we don't fully program the image sensor, which works with rather fixed settings, but mostly the GMSL interface <br> the requirement of a 'small' probe and to defer the i2c writes to a later init is mostly due to the GMSL bus, not much to the image sensor <br> (you can see in the driver, the rdacm20 particularly, the image sensor programming phase is limited to a list of reg-values pairs, that's mostly it) hverkuil: OK. As things are today this 'init' thing is very specific for these camera modules, and does not have to be a generic solution. This might change in the future, esp. if the sensor driver is split off, but it is not an issue today. <br> Correct? jmondi: regardless of the image sensor driver programming being embedded in the camera module driver, or performed by a separate subdev driver, the stability of the i2c communication depends on the ping-pong between the deserializer (connected to the SoC) and the serializer (on the remote side) ***: andrey-konovalov has quit IRC (Ping timeout: 480 seconds) jmondi: untile they do not stabilize the communication channel that travels on the GMSL bus, i2c communications are less reliable. That's why the probe() of the remote only serves to setup the control channel where i2c transactions travels on. Once this is done, we can 'init' the camera module by sending lots of i2c transactions <br> regardless how the camera modules are modeled, as a monolithic driver which uses a library driver for max9271, or with proper subdev drivers for each components <br> although, the requirement of using 'init()' if a GSML bus is used, would prevent the subdev driver to be a 'regular' one, as most of the initialization will be performed in init() and not in probe() <br> and the host driver should be aware and call init() opportunely ***: sukbeom has joined #linux-media jmondi: so I would say, the usage of init() is specific to the usage of GMSL, not much to the camera modules driver architecture <br> s/specific to the usage of GMSL/accomodates requirements of the GMSL bus/ ***: ao2 has quit IRC (Quit: Leaving) <br> sukbeom has quit IRC (Ping timeout: 480 seconds) <br> GBenji has quit IRC (Ping timeout: 480 seconds) <br> sukbeom has joined #linux-media <br> GBenji has joined #linux-media <br> GBenji has quit IRC (Ping timeout: 480 seconds) <br> sukbeom has quit IRC (Ping timeout: 480 seconds) <br> hverkuil has quit IRC (Quit: ZNC 1.8.1+deb1 - https://znc.in) <br> hverkuil has joined #linux-media ezequielg: <u>hverkuil</u>: fyi, I plan to review the new hantro hevc v2 series from Benjamin. ***: svarbanov has quit IRC (Ping timeout: 480 seconds) <br> GBenji has joined #linux-media <br> svarbanov has joined #linux-media hverkuil: <u>ezequielg</u>: ack ***: svarbanov has quit IRC () <br> svarbanov has joined #linux-media <br> GBenji has quit IRC (Ping timeout: 480 seconds) <br> GBenji has joined #linux-media <br> miqztee has joined #linux-media <br> svarbanov has quit IRC (Ping timeout: 480 seconds) <br> NiksDev has quit IRC () <br> miqztee has quit IRC (Remote host closed the connection) <br> andrey-konovalov has joined #linux-media <br> svarbanov has joined #linux-media tomba: <u>hverkuil</u>: did you mean to cc Laurent in "media: rcar-isp: Add Renesas R-Car Image Signal Processor driver". I don't know anything about r-car. ***: GBenji has quit IRC (Quit: Leaving.) hverkuil: <u>tomba</u>: I CC-ed you due to me referring to https://patchwork.linuxtv.org/project/linux-media/cover/20210524104408.599645-1-tomi.valkeinen@ideasonboard.com/ all the way down in that email. That wasn't very clear at all, sorry for the confusion. ***: gouchi has joined #linux-media tomba: ah, right =) ***: ao2 has joined #linux-media <br> gouchi has quit IRC (Remote host closed the connection) <br> lyakh_ has joined #linux-media <br> lyakh has quit IRC (Ping timeout: 480 seconds) <br> ao2 has quit IRC (Quit: Leaving) <br> jm_h has quit IRC (Remote host closed the connection) <br> andrey-konovalov has quit IRC (Ping timeout: 480 seconds) <br> NiksDev2 has quit IRC (Ping timeout: 480 seconds) <br> jernej has quit IRC (Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net) <br> jernej has joined #linux-media <br> Whoopie_ has joined #linux-media <br> Whoopie has quit IRC (Ping timeout: 480 seconds) <br> Whoopie_ is now known as Whoopie