<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>
***: camus has joined #linux-media
<br> camus1 has quit IRC (Ping timeout: 480 seconds)
<br> xiaer1921 has joined #linux-media
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Ping timeout: 480 seconds)
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Read error: Connection reset by peer)
<br> eelstrebor has quit IRC (Quit: Ex-Chat)
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Ping timeout: 480 seconds)
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Read error: Connection reset by peer)
<br> xiaer1922 has joined #linux-media
<br> xiaer1921 has quit IRC (Ping timeout: 480 seconds)
<br> xiaer1922 is now known as xiaer1921
<br> xiaer1921 has quit IRC (Remote host closed the connection)
<br> xiaer1921 has joined #linux-media
<br> jm_h has joined #linux-media
<br> jarthur has quit IRC (Remote host closed the connection)
<br> jarthur has joined #linux-media
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Ping timeout: 480 seconds)
<br> jarthur has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
<br> ao2 has joined #linux-media
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Read error: Connection reset by peer)
<br> gouchi has joined #linux-media
<br> gouchi has quit IRC (Remote host closed the connection)
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Ping timeout: 480 seconds)
<br> paulk has joined #linux-media
<br> djrscally has joined #linux-media
<br> camus1 has quit IRC (Remote host closed the connection)
<br> camus has joined #linux-media
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Ping timeout: 480 seconds)
<br> svarbanov has joined #linux-media
<br> GBenji has joined #linux-media
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Ping timeout: 480 seconds)
<br> sailorek1234 has joined #linux-media
wens: <u>hverkuil</u>: the kernel-docs and user API doc regarding the .data_offset field in |struct v4l2_plane| seems to imply that the field is valid for all three types of buffers (MMAP, USERPTR, DMABUF), is that true?
<br> ChromeOS has a bunch of downstream "hacks" to apply the offset to DMABUF buffers when passing the addresses to hardware. If these aren't actually hacks, maybe I should upstream them.
***: camus1 has joined #linux-media
wens: <u>hverkuil</u>: another question is whether V4L2_PIX_FMT_JPEG corresponds to any properly formatted JPEG stream with SOI to EOI markers, or does it has to follow JFIF and have JFIF-APP0?
***: camus has quit IRC (Ping timeout: 480 seconds)
andrzej_p: <u>hverkuil</u>: The change you suggested worked (with some change). Do you prefer a v9 or just a reply to the changed patch, or do you want to introduce the changes yourself?
hverkuil: <u>wens</u>: data_offset is valid for all types of buffers. Rarely used in drivers, though. In hindsight we shouldn't have added this field. Drivers set this field for capture, userspaces sets it for video output. So if that use matches what ChromeOS does, then it might make sense to upstream. But I suspect it does something different. Typically with capture it is used if some header with metadata or just plain garbage is in front of the v
<br> ideo data.
<br> <u>wens</u>: FMT_JPEG/MJPEG is for properly formatted JPEG streams, but additional JPEG markers can be added: https://linuxtv.org/downloads/v4l-dvb-apis-new/userspace-api/v4l/ext-ctrls-jpeg.html
<br> <u>andrzej_p</u>: the change is just in a single patch, right? Then just post that patch as a v8.1.
andrzej_p: ok
<br> done
hverkuil: <u>andrzej_p</u>: posted PR for the VP9 series! Thank you for the quick turn-around to fix my comments.
<br> Many thanks to everyone who worked on this or helped with testing it! Very nice to see this finally land.
***: xiaer1921 has quit IRC (Ping timeout: 480 seconds)
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Ping timeout: 480 seconds)
wens: <u>hverkuil</u>: it's mostly used on the output side for encoders, to send in planar frames that are put in a shared buffer
<br> <u>hverkuil</u>: ^ data_offset is *
***: cbdev has left
wens: <u>hverkuil</u>: as for "properly formatted JPEG streams", I take that to mean any stream with proper SOI SOS EOI markers
hverkuil: <u>wens</u>: jpeg: yes, proper SOI etc. markers.
<br> <u>wens</u>: data_offset for output buffers might well be a valid use-case that can be upstreamed.
***: eelstrebor has joined #linux-media
<br> eelstrebor has quit IRC (Remote host closed the connection)
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Ping timeout: 480 seconds)
<br> gouchi has joined #linux-media
<br> gouchi has quit IRC (Quit: Quitte)
<br> BrianG61UK__ has joined #linux-media
<br> BrianG61UK_ has quit IRC (Ping timeout: 480 seconds)
<br> BrianG61UK has quit IRC (Read error: Connection reset by peer)
<br> sailorek1234 has quit IRC ()
wens: <u>hverkuil</u>: thanks
ndufresne: <u>wens</u>: hverkuil: using data_offset for offsetting planes isn't according to the spec, even though chromium and gstreamer does that
<br> but you might be right that its only clearly invalid if trying to use that when importing buffers in Capture devices
<br> (example: you encoder use shared buffer, you capture uses multiple allocations and you'd like to import buffers allocated by the encoder in your capture, as the opposite is not possible)
<br> basically we can't use it to ensure compatibility of M and non-M variant of pixel formats (even though the HW usually have no issue supporting that)
***: eelstrebor has joined #linux-media
<br> jarthur has joined #linux-media
wens: <u>ndufresne</u>: could you elaborate on how it's not to spec? I mean the spec doesn't really set any limits
***: BrianG61UK has joined #linux-media
<br> BrianG61UK_ has joined #linux-media
<br> GBenji has quit IRC (Quit: Leaving.)
<br> svarbanov has quit IRC (Ping timeout: 480 seconds)
<br> gouchi has joined #linux-media
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Read error: Connection reset by peer)
<br> paulk has quit IRC (Ping timeout: 480 seconds)
<br> camus1 has joined #linux-media
<br> camus has quit IRC (Read error: Connection reset by peer)
<br> paulk has joined #linux-media
<br> ao2 has quit IRC (Quit: Leaving)
<br> darkapex1 has joined #linux-media
<br> darkapex has quit IRC (Ping timeout: 480 seconds)
ndufresne: <u>wens</u>: this has been discussed a lot on the ML before, but I can recollect the information for you, but now now
<br> not now
***: svarbanov has joined #linux-media
<br> svarbanov has quit IRC (Ping timeout: 480 seconds)
<br> svarbanov has joined #linux-media
<br> gouchi has quit IRC (Remote host closed the connection)
<br> jm_h has quit IRC (Remote host closed the connection)
<br> BrianG61UK__ has quit IRC (Quit: Leaving)
<br> camus has joined #linux-media
<br> camus1 has quit IRC (Ping timeout: 480 seconds)
<br> djrscally has quit IRC (Quit: Konversation terminated!)