| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | djrscally has quit IRC (Ping timeout: 480 seconds)
camus1 has joined #linux-media camus has quit IRC (Ping timeout: 480 seconds) | [00:13] |
| ............. (idle for 1h1mn) | ||
| camus has joined #linux-media
camus1 has quit IRC (Read error: Connection reset by peer) | [01:20] | |
| camus has quit IRC (Remote host closed the connection)
camus has joined #linux-media | [01:33] | |
| .... (idle for 16mn) | ||
| camus1 has joined #linux-media
camus has quit IRC (Ping timeout: 480 seconds) | [01:49] | |
| jernej has quit IRC (Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net) | [02:01] | |
| .......... (idle for 46mn) | ||
| darkapex1 has joined #linux-media | [02:47] | |
| darkapex has quit IRC (Ping timeout: 480 seconds) | [02:52] | |
| jernej has joined #linux-media | [03:01] | |
| BrianG61UK has quit IRC (Quit: Leaving)
BrianG61UK_ has quit IRC (Quit: Leaving) | [03:13] | |
| ...... (idle for 26mn) | ||
| BrianG61UK has joined #linux-media
BrianG61UK_ has joined #linux-media eelstrebor has joined #linux-media eelstrebor has quit IRC () | [03:39] | |
| .......... (idle for 49mn) | ||
| darkapex2 has joined #linux-media | [04:31] | |
| darkapex1 has quit IRC (Ping timeout: 480 seconds) | [04:37] | |
| ...................... (idle for 1h46mn) | ||
| sailorek1234 has joined #linux-media | [06:23] | |
| wens | ndufresne: AFAICT the Gstreamer v4l2* plugins set extra-controls before setting the output/capture formats. For Hantro's JPEG encoder this seems to make the driver "forget" the set JPEG quality. I assume that should be considered a bug? | [06:36] |
| *** | camus has joined #linux-media
camus1 has quit IRC (Ping timeout: 480 seconds) | [06:38] |
| pinchartl | wens: I'm sure that someone will complain that the JPEG quality uses a random value if we fix that :-) | [06:43] |
| *** | jm_h has joined #linux-media | [06:50] |
| wens | I assume the setting should be limited to the opened instance, but persist while the device is still opened? | [06:58] |
| *** | camus1 has joined #linux-media | [07:05] |
| pinchartl | in V4L2 settings persist when a device is closed, although I think it's different when using the M2M API
it's both useful and damaging, as it enables collaborative use cases with multiple applications involved, but can also result in destructive collaboration :-) | [07:06] |
| wens | the hantro jpeg encoder is probably too forgetful to be useful though :p
I'll see if I can't rework the logic | [07:09] |
| *** | camus has quit IRC (Ping timeout: 480 seconds) | [07:10] |
| camus has joined #linux-media | [07:21] | |
| camus1 has quit IRC (Ping timeout: 480 seconds) | [07:26] | |
| wens | ah, nevermind, it does work. It's just that the quality isn't so great to begin with :/ | [07:31] |
| ...... (idle for 28mn) | ||
| *** | djrscally has joined #linux-media | [07:59] |
| camus has quit IRC (Remote host closed the connection)
camus has joined #linux-media | [08:11] | |
| GBenji has joined #linux-media | [08:25] | |
| camus1 has joined #linux-media
camus has quit IRC (Ping timeout: 480 seconds) | [08:35] | |
| ao2 has joined #linux-media
gouchi has joined #linux-media Bugies has joined #linux-media | [08:46] | |
| gouchi has quit IRC (Remote host closed the connection) | [09:00] | |
| .................. (idle for 1h27mn) | ||
| wens | ndufresne: AFAICT Gstreamer v4l2jpegenc doesn't call the SELECTION/CROP APIs to handle non-macroblock-sized image dimensions?
I implemented the selection API for the Hantro driver and I need something to test mainline with Also, I'm not sure if I'm supposed to update the dimensions on the capture side to the cropped size (I assume the answer is yes) | [10:27] |
| *** | gouchi has joined #linux-media
camus1 has quit IRC (Remote host closed the connection) Bugies has quit IRC (Ping timeout: 480 seconds) camus has joined #linux-media | [10:34] |
| .......... (idle for 48mn) | ||
| ndufresne | wens: it should call g_selection yes
Sorry, s_selection, but not systematically, most encoders only allow non multiple width/height in their enumeration It's possible enum_framesize was meant to be padded size, but userspace like GST have used it as display size for 15years, I don't feel comfortable into changing that wens: about the size on the capture, it's a bit undefined for fomats that encode that information, but settings it to the display size make sense, otherwise you need g_selection, more work, not really needed | [11:23] |
| ................ (idle for 1h17mn) | ||
| *** | camus has quit IRC (Remote host closed the connection)
camus has joined #linux-media | [12:46] |
| camus1 has joined #linux-media
camus has quit IRC (Read error: Connection reset by peer) | [12:54] | |
| ndufresne | wens: p.s. could also be a bug :-) | [13:01] |
| ...... (idle for 28mn) | ||
| *** | djrscally has quit IRC (Quit: Konversation terminated!) | [13:29] |
| camus1 has quit IRC (Remote host closed the connection)
camus has joined #linux-media | [13:36] | |
| ...... (idle for 28mn) | ||
| camus1 has joined #linux-media
camus has quit IRC (Ping timeout: 480 seconds) | [14:04] | |
| ....... (idle for 31mn) | ||
| camus has joined #linux-media | [14:39] | |
| camus1 has quit IRC (Ping timeout: 480 seconds) | [14:44] | |
| BrianG61UK has quit IRC (Read error: Connection reset by peer) | [14:50] | |
| ..... (idle for 24mn) | ||
| sailorek1234 has quit IRC (Quit: sailorek1234) | [15:14] | |
| darkapex3 has joined #linux-media | [15:26] | |
| darkapex2 has quit IRC (Ping timeout: 480 seconds) | [15:31] | |
| wens | for s_fmt 640x360 on the output side, hantro gives back 640x368 | [15:33] |
| *** | gouchi has quit IRC (Remote host closed the connection) | [15:39] |
| ....... (idle for 32mn) | ||
| wens | and currently that causes gstreamer to output a 640x368 jpeg file | [16:11] |
| *** | Bugies has joined #linux-media | [16:12] |
| .... (idle for 18mn) | ||
| BrianG61UK has joined #linux-media | [16:30] | |
| ...... (idle for 26mn) | ||
| zlywilk_ has joined #linux-media | [16:56] | |
| zlywilk_ | hi | [16:56] |
| *** | zlywilk_ has quit IRC () | [16:59] |
| ndufresne | wens: hmm, this is not ideal,even if this is HW, this should work with 1 pixel steps really
this is rk3399 ? | [17:00] |
| *** | zlywilk_ has joined #linux-media
eelstrebor has joined #linux-media zlywilk_ has left | [17:03] |
| wens | yup
I know internally it should be 640x368, but I'm not sure what the output and capture formats should look like, or the crop/selection bits | [17:06] |
| *** | zlywilk has joined #linux-media | [17:09] |
| zlywilk | hi | [17:14] |
| *** | GBenji has left | [17:16] |
| ................ (idle for 1h17mn) | ||
| camus1 has joined #linux-media
camus has quit IRC (Ping timeout: 480 seconds) | [18:33] | |
| Bugies has quit IRC (Remote host closed the connection) | [18:41] | |
| ............ (idle for 59mn) | ||
| camus has joined #linux-media
zlywilk has quit IRC (Remote host closed the connection) camus1 has quit IRC (Read error: Connection reset by peer) | [19:40] | |
| ........... (idle for 50mn) | ||
| ao2 has quit IRC (Quit: Leaving) | [20:33] | |
| ...... (idle for 25mn) | ||
| jernej has quit IRC (Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net)
jernej has joined #linux-media | [20:58] | |
| .... (idle for 19mn) | ||
| jarthur has joined #linux-media | [21:17] | |
| ndufresne | wens: gst specific, caps should reflect the display size, S_FMT in v4l2 the padded size, ENUM fmt is in display size iirc, something in these line | [21:23] |
| wens: raw caps (display size) are sent to the encoder (but constrained by enum_fmt if implemented), then pass here: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-good/sys/v4l2/gstv4l2videoenc.c#L305
As a first step, it will negotiate the bitstream caps, basically check with downstream element which profile/level to use (not applicable to jpeg), and set that into the output state, the input state is passed, since the original display size will be copied into the bitstream caps, this is mostly for convenience, the size is optional as its available inside the bitstream for jpeg and then it calls gst_v4l2_object_set_format() for the OUTPUT queue (input), that will do S_FMT after translating all the parameters wens: so what I think you need, is add a call to gst_v4l2_object_set_crop() after gst_v4l2_object_set_format() that will set the selection according to the padding, which got saved from the different between input of S_FMT and the return value (from driver) hverkuil: somewhere next year, we should try and brainstorm on a flow to recover if we have a held capture buffer, but the expected next slice or field is missing basically undo the hold There also seem to be bugs, that if the decode for the hold fails, the next request apparently never get signal | [21:30] | |
| *** | jm_h has quit IRC (Remote host closed the connection) | [21:46] |
| ....... (idle for 30mn) | ||
| b-rad has quit IRC (Ping timeout: 480 seconds) | [22:16] | |
| ......... (idle for 43mn) | ||
| camus1 has joined #linux-media
camus has quit IRC (Read error: Connection reset by peer) | [22:59] | |
| .... (idle for 17mn) | ||
| b-rad has joined #linux-media | [23:17] | |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |