<!-- Some styling for better description lists --><style type='text/css'>dt { font-weight: bold;float: left;display:inline;margin-right: 1em} dd { display:block; margin-left: 2em}</style>
bryanodonoghue: unlike on imx219 or hi556
<br> or indeed ov5675
<br> Surely setting exposure from user-space is a uniform thing on sensors ?
<br> lower passed values mean lower exposure
<br> there's a repeated pattern in the imx sensors though
<br> drivers/media/i2c/imx334.c::imx334_update_exp_gain()
<br> lpfr = imx334->vblank + imx334->cur_mode->height;
<br> shutter = lpfr - exposure;
<br> ret = imx334_write_reg(imx334, IMX334_REG_SHUTTER, 3, shutter)
<br> if the range is 8 to FFF
***: mrpops2ko has joined #linux-media
bryanodonoghue: what will happen here is setting a high exposure value of say FFC
<br> shutter will end up something very small
<br> 0x04 as a simple example
<br> so to set a higher exposure you have to invert the logic
<br> this seems like a copy/paste bug in these sensors
<br> I noticed this when doing libcamera SoftISP validation on RB5
<br> the algorithm works on the x13s with the ov5675
<br> works on RB5 with the imx219
<br> and works for hans on the IPU6
<br> sensor == hi556
<br> all of which directly take the passed exposure value and give it to the sensor
<br> so surely *that* is the contract from user-space to kernel
<br> and the imx sensors have a bug..
<br> KieranBingham[m] pinchartl
***: Whoopie_ has joined #linux-media
<br> Whoopie has quit IRC (Read error: Connection reset by peer)
<br> Whoopie_ is now known as Whoopie
<br> Whoopie has quit IRC (Read error: Connection reset by peer)
<br> Whoopie_ has joined #linux-media
<br> Whoopie_ is now known as Whoopie
<br> danitool has quit IRC (Ping timeout: 480 seconds)
<br> mrpops2ko has quit IRC ()
<br> mrpops2ko has joined #linux-media
<br> eelstrebor has quit IRC (Quit: Ex-Chat)
<br> xecutercmd has joined #linux-media
<br> xecutertool has quit IRC (Ping timeout: 480 seconds)
<br> robertfoss has quit IRC (Ping timeout: 480 seconds)
<br> robertfoss has joined #linux-media
<br> mrpops2ko has quit IRC (Remote host closed the connection)
<br> mrpops2ko has joined #linux-media
<br> mvaittin has quit IRC (Ping timeout: 480 seconds)
<br> mvaittin has joined #linux-media
<br> GBenji has joined #linux-media
<br> mrpops2ko has quit IRC ()
<br> mrpops2ko has joined #linux-media
<br> mripard has joined #linux-media
<br> ao2 has joined #linux-media
jmondi: <u>bryanodonoghue</u>: sounds like something to fix in the driver indeed, as the userspace you're talking about is libcamera I presume you're controlling the sensor exposure with V4L2_CID_EXPOSURE (and ANALOGUE_GAIN). The kernel doc for EXPOSURE is not yet been fixed and doesn't specify a measure unit, but it's generally accepted (and required by libcamera) to have exposure expressed in
<br> number of lines
<br> (see Documentation/sensor_driver_requirements.rst in libcamera sources)
***: ao2 has quit IRC (Remote host closed the connection)
<br> Moarc has quit IRC (Quit: i znowu NADMUCHAÅ BALONA)
<br> robertfoss has quit IRC (Ping timeout: 480 seconds)
<br> Moarc has joined #linux-media
pinchartl: <u>bryanodonoghue</u>: I agree with Jacopo, the driver should be fixed
***: lplc has quit IRC (Remote host closed the connection)
<br> lplc has joined #linux-media
<br> frieder has joined #linux-media
<br> robertfoss has joined #linux-media
<br> lplc has quit IRC (Ping timeout: 480 seconds)
<br> frieder has quit IRC (Ping timeout: 480 seconds)
<br> lplc has joined #linux-media
<br> frieder has joined #linux-media
<br> frieder has quit IRC (Remote host closed the connection)
<br> frieder has joined #linux-media
<br> ao2 has joined #linux-media
bryanodonoghue: jmondi pinchartl great so, looks like a copy/paste several times
***: jernej has quit IRC (Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net)
<br> jernej has joined #linux-media
<br> BrianG61UK has joined #linux-media
<br> mriesch has joined #linux-media
<br> mriesch has quit IRC ()
<br> mriesch has joined #linux-media
<br> mriesch has quit IRC ()
<br> mriesch has joined #linux-media
<br> mriesch has quit IRC ()
<br> mriesch has joined #linux-media
<br> frieder has quit IRC (Ping timeout: 480 seconds)
<br> mriesch has quit IRC ()
<br> mriesch has joined #linux-media
<br> xecutercmd has quit IRC (Remote host closed the connection)
<br> mvaittin has quit IRC (Ping timeout: 480 seconds)
<br> frieder has joined #linux-media
<br> eelstrebor has joined #linux-media
<br> eelstrebor has quit IRC ()
<br> mriesch has quit IRC ()
<br> mriesch has joined #linux-media
<br> xroumegue has quit IRC (Ping timeout: 480 seconds)
<br> xroumegue has joined #linux-media
<br> frieder has quit IRC (Remote host closed the connection)
<br> GBenji has quit IRC (Ping timeout: 480 seconds)
<br> BrianG61UK has quit IRC (Ping timeout: 480 seconds)
<br> BrianG61UK has joined #linux-media
<br> gouchi has joined #linux-media
<br> gouchi has quit IRC (Remote host closed the connection)
<br> jarthur has joined #linux-media
<br> ten1572377432463050 has quit IRC (Remote host closed the connection)
<br> ten1572377432463050 has joined #linux-media
<br> cphealy has joined #linux-media
<br> danitool has joined #linux-media
<br> jernej has quit IRC (Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net)
<br> jernej has joined #linux-media
<br> ten1572377432463050 has quit IRC (Remote host closed the connection)
<br> ten1572377432463050 has joined #linux-media
<br> ao2 has quit IRC (Quit: Leaving)
<br> jarthur has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
<br> jarthur has joined #linux-media
<br> jarthur has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
<br> djrscally has joined #linux-media
<br> djrscally has quit IRC (Ping timeout: 480 seconds)
<br> xecuter has joined #linux-media