| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | digetx has quit IRC (Ping timeout: 480 seconds)
digetx has joined #linux-media | [00:37] |
| ............................. (idle for 2h21mn) | ||
| mrpops2ko has quit IRC ()
mrpops2ko has joined #linux-media | [03:01] | |
| ........................ (idle for 1h55mn) | ||
| nas_chung has joined #linux-media
mvaittin has joined #linux-media nas_chung has quit IRC () | [04:57] | |
| .......... (idle for 47mn) | ||
| ten1572377432463050661821 has quit IRC (Ping timeout: 480 seconds) | [05:48] | |
| ........ (idle for 35mn) | ||
| djrscally has joined #linux-media
ao2 has joined #linux-media | [06:23] | |
| xroumegue has quit IRC (Ping timeout: 480 seconds) | [06:34] | |
| xroumegue has joined #linux-media | [06:42] | |
| .... (idle for 18mn) | ||
| mvaittin has quit IRC (Ping timeout: 480 seconds) | [07:00] | |
| ...... (idle for 28mn) | ||
| mvaittin has joined #linux-media | [07:28] | |
| hverkuil | jmondi: was the pisp_be driver ever checked with v4l2-compliance? I noticed that pispbe_node_queue_ops didn't set the wait_prepare/finish ops, and I believe v4l2-compliance would fail on that. | [07:30] |
| *** | frieder has joined #linux-media | [07:32] |
| jmondi | hverkuil: I did (at least according to the cover letter I sent)
hverkuil: I'm working on it to address Laurent's comments so I can re-test | [07:35] |
| hverkuil | It's only seen if you run with the -s option. That's probably the root cause. | [07:38] |
| *** | prabhakalad has quit IRC (Quit: Konversation terminated!) | [07:38] |
| jmondi | ah maybe I didn't do that | [07:39] |
| hverkuil | Although thinking it over, that particular test can probably be run without the streaming tests. | [07:39] |
| pinchartl | I doubt v4l2-compliance will be able to test streaming on the pispbe driver | [07:40] |
| hverkuil | That specific test doesn't actually queue buffers.
It allocates two buffers and calls STREAMON. Then it starts two threads: one calls DQBUF (will wait indefinitely since no buffers are queued), and the other calls STREAMOFF. That streamoff should succeed if the locking is handled correctly. If wait_prepare/finish isn't set, then that test will fail. | [07:41] |
| .... (idle for 19mn) | ||
| svarbanov: I noticed that the venus driver also doesn't set the wait_prepare/finish ops. I suspect that the venus driver has the same problem as the pisp_be driver (discussed above).
I have changed v4l2-compliance so that it performs the blocking wait test even if the -s option wasn't specified. Can you verify that this is indeed a venus driver bug? | [08:02] | |
| *** | prabhakalad has joined #linux-media | [08:06] |
| pinchartl | hverkuil: there's a single driver that has custom handlers for those two operations
drivers/media/dvb-core/dvb_vb2.c could we fix that and drop the ops ? | [08:06] |
| hverkuil | That's OK, that's the dvb core vb2 driver. | [08:06] |
| pinchartl | or at least default them to vb2_ops_wait_prepare and vb2_ops_wait_finish ?
so that drivers won't have to to it manually and we can avoid these bugs in the future ? | [08:06] |
| hverkuil | There are three more drivers that do not set wait_prepare/finish: omap3isp, omap4iss and atomisp.
And yes, I believe this should be moved away from drivers. Which is why I am now looking at this. | [08:07] |
| *** | sgruszka has joined #linux-media | [08:08] |
| pinchartl | :-) | [08:09] |
| hverkuil | I think omap3isp will fail this test as well: isp_video_dqbuf locks video->queue_lock, but without a custom wait_prepare/finish this will block isp_video_streamoff.
Probably the same is true for omap4 | [08:10] |
| pinchartl | I think Sakari can test omap3isp
I can't test omap4iss, I doubt anyone still uses that driver | [08:12] |
| hverkuil | Is it time to drop omap4iss? | [08:13] |
| pinchartl | probably | [08:14] |
| *** | mripard has joined #linux-media | [08:14] |
| pinchartl | pinchartl sheds a tear | [08:14] |
| hverkuil | pinchartl: would it make sense to drop omap4iss immediately, or move it to drivers/staging/media/deprecated/ and remove it 1-2 kernel cycles later? | [08:23] |
| pinchartl | I think it could be removed immediately | [08:24] |
| hverkuil | I'll prepare a patch. | [08:24] |
| javierm | pinchartl, hverkuil: I've a OMAP4 pandaboard in a drawer but haven't booted in a decade...
FYI u-boot recently removed support for all OMAP4 boards https://lists.denx.de/pipermail/u-boot/2024-July/558846.html | [08:29] |
| pinchartl | javierm: I also have one in a drawer :-) | [08:30] |
| hverkuil | me too :-) | [08:30] |
| javierm | :) there was a time that every Linux developer involved with ARM had an OMAP board over their desk | [08:32] |
| ..................... (idle for 1h44mn) | ||
| *** | ten1572377432463050661821 has joined #linux-media | [10:16] |
| .............. (idle for 1h5mn) | ||
| prabhakalad | pinchartl: with introduction to streams api, for virtual channels on sensors should we be creating pads for each channel? If I remember previously during the CRU work the streams api was WIP there was a comment saying we dont need pads for virtual channel. | [11:21] |
| pinchartl | prabhakalad: no, you don't need multiple pads
you will have a single source pad, with one stream per VC there will be "internal pads" too, which is a concept we're introducting, it's not in mainline yet | [11:31] |
| *** | mvaittin has quit IRC (Ping timeout: 480 seconds) | [11:36] |
| prabhakalad | thanks, I was going through the latest patch series from Tomi for RPI which has streams API where csi support 4 channels there are 4 pads created.
> +#define CSI2_NUM_CHANNELS 4 > + > +#define CSI2_PAD_SINK 0 > +#define CSI2_PAD_FIRST_SOURCE 1 > +#define CSI2_PAD_NUM_SOURCES 4 > +#define CSI2_NUM_PADS 5 https://www.spinics.net/lists/linux-media/msg260931.html | [11:40] |
| pinchartl | those are the source pads of the CSI-2 receiver
the CSI-2 RX has a single sink pad, on which it receives all VCs and that particular device has 4 outputs | [11:43] |
| prabhakalad | ahh got you, sorry for the confusion. | [11:45] |
| pinchartl | no worries | [11:46] |
| prabhakalad | thank you. | [11:47] |
| .................. (idle for 1h25mn) | ||
| *** | tmerciai1 has quit IRC (Remote host closed the connection) | [13:12] |
| ............ (idle for 55mn) | ||
| andrzej_p32 has quit IRC (Quit: The Lounge - https://thelounge.chat)
digetx is now known as Guest2214 digetx has joined #linux-media Guest2214 has quit IRC (Ping timeout: 480 seconds) | [14:07] | |
| .... (idle for 15mn) | ||
| sgruszka has quit IRC (Ping timeout: 480 seconds)
eelstrebor has joined #linux-media | [14:23] | |
| eelstrebor has quit IRC (Quit: Ex-Chat) | [14:32] | |
| ....... (idle for 33mn) | ||
| nickware has quit IRC (Remote host closed the connection)
nickware has joined #linux-media | [15:05] | |
| .... (idle for 16mn) | ||
| prabhakalad | just trying my luck, anyone know a 22pin mipi camera which I can buy off the shelf? | [15:22] |
| pinchartl | 22-pin as in compatible with the Raspberry Pi pinout ? | [15:23] |
| prabhakalad | pinchartl: Yes with RPI pinout. | [15:24] |
| pinchartl | get any rpi 15-pin camera module, and add a https://www.adafruit.com/product/5818 cable
or use https://thepihut.com/products/camera-cable-joiner-for-raspberry-pi-15-pin-to-22-pin as an adapter board | [15:25] |
| prabhakalad | pinchartl: thanks :) | [15:30] |
| ..... (idle for 21mn) | ||
| *** | sgruszka has joined #linux-media
frieder has quit IRC (Remote host closed the connection) | [15:51] |
| sgruszka has quit IRC (Quit: Leaving) | [16:07] | |
| digetx has quit IRC (Ping timeout: 480 seconds) | [16:18] | |
| ..... (idle for 20mn) | ||
| digetx has joined #linux-media | [16:38] | |
| ............ (idle for 59mn) | ||
| ao2 has quit IRC (Quit: Leaving) | [17:37] | |
| ............ (idle for 55mn) | ||
| fedora has joined #linux-media | [18:32] | |
| ........ (idle for 37mn) | ||
| fedora has quit IRC ()
gouchi has joined #linux-media | [19:09] | |
| .... (idle for 17mn) | ||
| darkapex has quit IRC (Remote host closed the connection)
darkapex has joined #linux-media | [19:29] | |
| ........... (idle for 51mn) | ||
| jmassot_ has joined #linux-media
Moarc_ has joined #linux-media digetx_ has joined #linux-media paulk-bis has joined #linux-media digetx has quit IRC (reticulum.oftc.net helix.oftc.net) ten1572377432463050661821 has quit IRC (reticulum.oftc.net helix.oftc.net) mripard has quit IRC (reticulum.oftc.net helix.oftc.net) prabhakalad has quit IRC (reticulum.oftc.net helix.oftc.net) xroumegue has quit IRC (reticulum.oftc.net helix.oftc.net) djrscally has quit IRC (reticulum.oftc.net helix.oftc.net) jmassot has quit IRC (reticulum.oftc.net helix.oftc.net) Moarc has quit IRC (reticulum.oftc.net helix.oftc.net) paulk has quit IRC (reticulum.oftc.net helix.oftc.net) Kwiboo has quit IRC (reticulum.oftc.net helix.oftc.net) AndyCap has quit IRC (reticulum.oftc.net helix.oftc.net) tomba has quit IRC (reticulum.oftc.net helix.oftc.net) z3ntu has quit IRC (reticulum.oftc.net helix.oftc.net) djrscally[m] has quit IRC (reticulum.oftc.net helix.oftc.net) prabhakalad has joined #linux-media Kwiboo has joined #linux-media AndyCap has joined #linux-media digetx has joined #linux-media ten1572377432463050661821 has joined #linux-media mripard has joined #linux-media xroumegue has joined #linux-media djrscally has joined #linux-media jmassot has joined #linux-media paulk has joined #linux-media tomba has joined #linux-media z3ntu has joined #linux-media djrscally[m] has joined #linux-media z3ntu has quit IRC (Ping timeout: 480 seconds) ten15723774324630506618216 has joined #linux-media paulk has quit IRC (Read error: Network is unreachable) ten1572377432463050661821 has quit IRC (Ping timeout: 480 seconds) ten15723774324630506618216 is now known as ten1572377432463050661821 digetx has quit IRC (Ping timeout: 480 seconds) djrscally has quit IRC (Ping timeout: 480 seconds) jmassot has quit IRC (Ping timeout: 480 seconds) mripard has quit IRC (Ping timeout: 480 seconds) z3ntu has joined #linux-media | [20:20] | |
| .......... (idle for 45mn) | ||
| gouchi has quit IRC (Remote host closed the connection) | [21:15] | |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |