| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |
| Who | What | When |
|---|---|---|
| *** | broski[m] has quit IRC (autokilled: This host violated network policy and has been banned. Mail support@oftc.net if you think this is in error. (2025-04-02 00:56:48)) | [00:56] |
| ............. (idle for 1h2mn) | ||
| sigmaris_ has quit IRC (Remote host closed the connection)
alarumbe has quit IRC (Remote host closed the connection) alarumbe has joined #linux-media sigmaris has joined #linux-media BrianG61UK has quit IRC (Ping timeout: 480 seconds) BrianG61UK has joined #linux-media | [01:58] | |
| ........... (idle for 53mn) | ||
| epoll has quit IRC (Ping timeout: 480 seconds)
danitool has quit IRC (Remote host closed the connection) | [02:57] | |
| epoll has joined #linux-media | [03:07] | |
| ............... (idle for 1h12mn) | ||
| mvchtz has quit IRC (Remote host closed the connection)
mvchtz has joined #linux-media | [04:19] | |
| ................... (idle for 1h33mn) | ||
| ten157237743246305066182150355 has quit IRC (Remote host closed the connection)
ten157237743246305066182150355 has joined #linux-media | [05:53] | |
| dcz_ has joined #linux-media | [06:03] | |
| ..... (idle for 21mn) | ||
| djrscally has joined #linux-media | [06:24] | |
| dcz_ has quit IRC (Quit: Konversation terminated!) | [06:37] | |
| ao2 has joined #linux-media | [06:47] | |
| tmerciai has joined #linux-media | [06:52] | |
| ....... (idle for 30mn) | ||
| frieder has joined #linux-media | [07:22] | |
| sgruszka has joined #linux-media | [07:32] | |
| ..... (idle for 24mn) | ||
| hverkuil | mripard: can you send another test email? My provider claims that the issue with tor.source.kernel.org is resolved. Wait perhaps an hour before sending, I don't know if the changes they made are immediate. | [07:56] |
| ....... (idle for 32mn) | ||
| *** | svarbanov_ has quit IRC (Remote host closed the connection)
svarbanov_ has joined #linux-media | [08:28] |
| ..... (idle for 24mn) | ||
| gouchi has joined #linux-media
gouchi has quit IRC (Remote host closed the connection) | [08:52] | |
| ..... (idle for 24mn) | ||
| Mo has joined #linux-media | [09:16] | |
| ........... (idle for 50mn) | ||
| mvaittin has joined #linux-media | [10:06] | |
| ............ (idle for 56mn) | ||
| mripard | hverkuil: just sent one | [11:02] |
| hverkuil | mripard: got it! | [11:11] |
| ....... (idle for 32mn) | ||
| mripard | \o/ | [11:43] |
| ....... (idle for 34mn) | ||
| bemug46 | Hi, I'm having trouble understanding the review from Krzysztof, can anyone help me finding what I need to do in my device tree binding file ?
https://lore.kernel.org/linux-media/20250401-b4-vd55g1-v2-0-0c8ab8a48c55@foss.st.com/T/#m3ad93addb2ea6f87a05cabd7857f7b93b60fce01 I thought my v3 was correct with const and maxItems but I guess it's not. I'm not very knowledgeable in device tree specificities | [12:17] |
| *** | sgruszka has quit IRC (Ping timeout: 480 seconds) | [12:31] |
| pinchartl | bemug46: I tend to ignore his reviews, but patches then don't necessarily get merged quickly
I consider his behaviour on mailing lists abusive | [12:39] |
| bemug46 | pinchartl thank you for your input, then I'll let my v3 as is for now and let media-maintainers reviewing it without adding extra noise to the line
I can edit my binding file later on | [12:42] |
| pinchartl | I think he meant
data-lanes: items: const: 1 | [12:43] |
| bemug46 | I thought too, but that's what I've done in V2, leading to this reply chain.
I'm confused | [12:44] |
| pinchartl | indeed that's what you did
I've replied to your e-mail or rather to Krzysztof's e-mail without a more constructive answer, I think you can send v3 ignoring this and if Krzysztof is still unhappy but doesn't want to tell why, I'm fine merging the bindings without his ack | [12:45] |
| bemug46 | your help is very appreciated, thank you
I already sent a v3 with what I thought was the right thing to do : adding a maxItems: 1 anyway let's see | [12:48] |
| .... (idle for 17mn) | ||
| mvaittin | bdmug46: I _truly_ _suck_ at writing the bindings, but I see Krzk's suggestion has a dash before the "const: 1" Vs. "- const: 1". Not sure if this dashed one implies the number of items w/o the maxItems. | [13:05] |
| pinchartl | indeed
but if that's the mistake... *sigh* I can't express my current feeling in any polite way, so I won't | [13:09] |
| mvaittin | pinchartl: You have been long enough in these business to know that people are different ... :) Dealing with reviews is _very_ frustrating at times, and has probably as good impact to development as very thick syrup has in a precision clock.
Krzk is still a nice guy to have a beer and a chat with ;) I suspect this job brings the worst out of us ;) | [13:12] |
| pinchartl | mvaittin: I'm not judging his ability to have a pleasant conversation around of a beer
I'm not judging him as a person I'm judging his repeated behaviour on mailing lists | [13:14] |
| mvaittin | pinchartl: I know | [13:14] |
| broonie | The DT reviews do seem to have been trending a bit better overall. | [13:14] |
| pinchartl | I can find excuses for mistakes, but not for a behaviour that is repeated countless times, despite multiple people complaining it's not acceptable | [13:14] |
| mvaittin | pinchartl: valid point. | [13:15] |
| pinchartl | to preserve my mental health, I've decided to ignore Krzysztof's DT reviews when he decides to escalate in an aggressive way. he may have a technical point, and the resulting bindings may be worse, but I don't care | [13:17] |
| mvaittin | Oh, and when I wrote that dealing with reviews is frustrating at times, I was writing from code author's perspective. Though, I suppose it can be frustrating from reviewer's perspective too. | [13:17] |
| pinchartl | reviews, as a reviewer, is a tiring and thankless job. when you spend your days only doing reviews, it's horrible | [13:18] |
| mvaittin | pinchartl: Definitely tiring and thankless. I've always found reading code much harder than writing. Also reading my own code.
And people are rarely genuinely thankful when someone points a flaw in their work :) sometimes some are, but overall - I don't think so. Anyways, I'll call it a day and quit my job for today (before my mental health is gone). Enjoy your evening! | [13:19] |
| pinchartl | mvaittin: nauti auringosta :-) | [13:23] |
| mvaittin | pinchartl: Kiitos! Ja nautin sitten kun se paistaa. Täällä on nyt varsin harmaata - mutta lämmintä! Tiet sulana joten aika huoltaa moottoripyörät ;) | [13:25] |
| bemug46 | mvaittin oh thank you you're right, I didn't put the '-', it may be it. | [13:29] |
| *** | Mo has quit IRC (Remote host closed the connection) | [13:30] |
| pinchartl | mvaittin: oh, is there still ice on the roads up there ? | [13:30] |
| bemug46 | I can't find anything about when to use a dash or not | [13:30] |
| pinchartl | Helsingissä on nyt jäätelöaika :-)
bemug46: with a dash it means a list of one item, which is the right thing to have | [13:31] |
| bemug46 | I see, so that's the issue
I'll submit a v4 with this change | [13:32] |
| .... (idle for 17mn) | ||
| Just sent, thanks a lot
it makes perfect sense now | [13:50] | |
| _0andriy_ | pinchartl: I can agree that his reviewsrequire a bit of brain activity to understand, but so far personally I have had no big issues with that (OTOH, I'm not sending DT patches often). | [13:51] |
| pinchartl | some of his reviews are not abusive, you may have been lucky :-) | [13:55] |
| ..... (idle for 20mn) | ||
| *** | sgruszka has joined #linux-media | [14:15] |
| _0andriy_ | mvaittin: revcently I have got a response from an author to my review of his code (to be clear, it's NOT Krzysztof) in a very unpolite way, so what should I do? :-)
bemug46: As far as I understand the - is a prefix for the list. When you put items, it expects the list of items. In any case, have you run the latest DT validator? if it's not complaining, then it's their problem as well. | [14:16] |
| bemug46 | _0andriy_ yes '-' is a list, I guess "maxItems: 1; const: 1" and "- const: 1" are in fact the same thing. The first one is a list of 1 item max, and every item must be 1, the later is a list of 1 item that must be 1
I ran 'make dt_binding_check' before sending my serie and it said nothing. But since both syntaxes must be valid it should be expected. It's just that the one with the dash is better | [14:24] |
| ............ (idle for 59mn) | ||
| *** | ao2 has quit IRC (Remote host closed the connection) | [15:24] |
| ..... (idle for 20mn) | ||
| frieder has quit IRC (Remote host closed the connection) | [15:44] | |
| .... (idle for 16mn) | ||
| ten157237743246305066182150355 has quit IRC (Remote host closed the connection)
ten157237743246305066182150355 has joined #linux-media | [16:00] | |
| BrianG61UK has quit IRC (Read error: Connection reset by peer) | [16:10] | |
| ........ (idle for 37mn) | ||
| tmerciai1 has joined #linux-media | [16:47] | |
| tmerciai has quit IRC (Ping timeout: 480 seconds) | [16:53] | |
| tmerciai1 has quit IRC (Ping timeout: 480 seconds) | [17:00] | |
| .............. (idle for 1h8mn) | ||
| dcz_ has joined #linux-media | [18:08] | |
| m1gr has quit IRC (Quit: m1gr) | [18:20] | |
| m1gr has joined #linux-media | [18:32] | |
| .... (idle for 15mn) | ||
| sgruszka has quit IRC (Ping timeout: 480 seconds) | [18:47] | |
| ........... (idle for 54mn) | ||
| dcz_ has quit IRC (Quit: Konversation terminated!) | [19:41] | |
| ........ (idle for 35mn) | ||
| sgruszka has joined #linux-media | [20:16] | |
| sgruszka has quit IRC (Quit: Leaving) | [20:26] | |
| _0andriy_ | bemug46: that command uses what exactly? I don't remember how I managed, but what I'm sure about is that distro installed DT checker is quite outdated. I had to have it installed via pip. | [20:37] |
| ................ (idle for 1h18mn) | ||
| *** | BrianG61UK has joined #linux-media | [21:55] |
| ↑back Search ←Prev date Next date→ Show only urls | (Click on time to select a line by its url) |