mripard: can you send another test email? My provider claims that the issue with tor.source.kernel.org is resolved. Wait perhaps an hour before sending, I don't know if the changes they made are immediate.
hverkuil: just sent one 
mripard: got it!
\o/
Hi, I'm having trouble understanding the review from Krzysztof, can anyone help me finding what I need to do in my device tree binding file ?
https://lore.kernel.org/linux-media/20250401-b4-vd55g1-v2-0-0c8ab8a48c55@foss.st.com/T/#m3ad93addb2ea6f87a05cabd7857f7b93b60fce01
I thought my v3 was correct with const and maxItems but I guess it's not. I'm not very knowledgeable in device tree specificities
bemug46: I tend to ignore his reviews, but patches then don't necessarily get merged quickly
I consider his behaviour on mailing lists abusive
pinchartl thank you for your input, then I'll let my v3 as is for now and let media-maintainers reviewing it without adding extra noise to the line
I can edit my binding file later on
I think he meant
          data-lanes:
            items:
              const: 1
I thought too, but that's what I've done in V2, leading to this reply chain.
I'm confused
indeed that's what you did
I've replied to your e-mail
or rather to Krzysztof's e-mail
without a more constructive answer, I think you can send v3 ignoring this
and if Krzysztof is still unhappy but doesn't want to tell why, I'm fine merging the bindings without his ack
your help is very appreciated, thank you
I already sent a v3 with what I thought was the right thing to do : adding a maxItems: 1
anyway let's see
bdmug46: I _truly_ _suck_ at writing the bindings, but I see Krzk's suggestion has a dash before the "const: 1" Vs. "- const: 1". Not sure if this dashed one implies the number of items w/o the maxItems.
indeed
but if that's the mistake... *sigh*
I can't express my current feeling in any polite way, so I won't
pinchartl: You have been long enough in these business to know that people are different ... :) Dealing with reviews is _very_ frustrating at times, and has probably as good impact to development as very thick syrup has in a precision clock.
Krzk is still a nice guy to have a beer and a chat with ;)
I suspect this job brings the worst out of us ;)
mvaittin: I'm not judging his ability to have a pleasant conversation around of a beer
I'm not judging him as a person
I'm judging his repeated behaviour on mailing lists
pinchartl: I know
The DT reviews do seem to have been trending a bit better overall.
I can find excuses for mistakes, but not for a behaviour that is repeated countless times, despite multiple people complaining it's not acceptable
pinchartl: valid point.
to preserve my mental health, I've decided to ignore Krzysztof's DT reviews when he decides to escalate in an aggressive way. he may have a technical point, and the resulting bindings may be worse, but I don't care
Oh, and when I wrote that dealing with reviews is frustrating at times, I was writing from code author's perspective. Though, I suppose it can be frustrating from reviewer's perspective too.
reviews, as a reviewer, is a tiring and thankless job. when you spend your days only doing reviews, it's horrible
pinchartl: Definitely tiring and thankless. I've always found reading code much harder than writing. Also reading my own code.
And people are rarely genuinely thankful when someone points a flaw in their work :)
sometimes some are, but overall - I don't think so.
Anyways, I'll call it a day and quit my job for today (before my mental health is gone). Enjoy your evening!
mvaittin: nauti auringosta :-)
pinchartl: Kiitos! Ja nautin sitten kun se paistaa. Täällä on nyt varsin harmaata - mutta lämmintä! Tiet sulana joten aika huoltaa moottoripyörät ;)
mvaittin oh thank you you're right, I didn't put the '-', it may be it.
mvaittin: oh, is there still ice on the roads up there ?
I can't find anything about when to use a dash or not
Helsingissä on nyt jäätelöaika :-)
bemug46: with a dash it means a list of one item, which is the right thing to have
I see, so that's the issue
I'll submit a v4 with this change
Just sent, thanks a lot
it makes perfect sense now
pinchartl: I can agree that his reviewsrequire a bit of brain activity to understand, but so far personally I have had no big issues with that (OTOH, I'm not sending DT patches often).
some of his reviews are not abusive, you may have been lucky :-)
mvaittin: revcently I have got a response from an author to my review of his code (to be clear, it's NOT Krzysztof) in a very unpolite way, so what should I do? :-)
bemug46: As far as I understand the - is a prefix for the list. When you put items, it expects the list of items. In any case, have you run the latest DT validator? if it's not complaining, then it's their problem as well.
_0andriy_ yes '-' is a list, I guess "maxItems: 1; const: 1" and "- const: 1" are in fact the same thing. The first one is a list of 1 item max, and every item must be 1, the later is a list of 1 item that must be 1
I ran 'make dt_binding_check' before sending my serie and it said nothing. But since both syntaxes must be valid it should be expected. It's just that the one with the dash is better
bemug46: that command uses what exactly? I don't remember how I managed, but what I'm sure about is that distro installed DT checker is quite outdated. I had to have it installed via pip.