[linux-dvb] bug in mpegtools ??

[michal <michal@etc.cz>]

I tried to use insert_pat_pmt and I found out that it generates bad 
continuity counter in PAT/PMT packets.

In function insert_pat_pmt in transform.c is this code
               tspid0[3] |= (c0++)
                       & 0x0F ;
               tspid1[3] |= (c1++)
                       & 0x0F ;

It produces this sequence:
0x?0, 0x?0, 0x?1, 0x?3, 0x?3, 0x?7, 0x?7, 0x?7, 0x?7, 0x?F and then 0x?F 
forever.

Shouldn't look the code like this?
               tspid0[3] = (tspid0[3] & 0xF0) | ((++c0) & 0x0F);
               tspid1[3] = (tspid1[3] & 0xF0) | ((++c1) & 0x0F);


Michal



--
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.