--On Tuesday, August 19, 2003 12:45:35 PM +0200 Johannes Stezenbach
<js@convergence.de> wrote:
> Looks good, but there's a problem: I currently don't have time to
> port changes to DVB forward to dvb-kernel, which means if you want
> me to apply changes to DVB you (or someone else) will have to send
> me similar patches for dvb-kernel.
Attached for "ves1820.c", "av7110.c" is on hold because I believe a
structure has changed...(see other e-mail).
>> Add pwm option to module:
>> ves1820-logunified-to-pwmoption.c.diff
>> (note: CLKCONF and CARCONF support are removed because they are no longer
>> needed)
>>
>> Mho: not so big chance for commit to current version, Holger don't like
>> module option, but perhaps more users can convince him to accept it ;-)
>
> I would apply this, because I think it's useful, and I don't know if the
> EEPROM is writable at all (could be write-protected), and if it is
> writable you could shoot yourself in the foot by writing crap to it.
> Also there's no utility for writing the EPPROM.
>
> But I need similar patch for dvb-kernel first.
Attached.
>> Limit AFC logging to a limit of lines per card and per 'init chip'
>> ves1820-pwmoption-AFCloglimit.c.diff
>>
>> Mho: not very sure that this patch would be commited to current version,
>> perhaps, if some users vote for it ;-)
>
> I don't like this. IMHO the VES1820 driver should
> always printk the PWM value from EEPROM during initialization.
> AFC can be printed with Jaakko's utility. We just need a pointer
> to it and a "howto fix dvb-c tuning problems" doc.
Attached, too, perhaps this makes one happier ;-)
BTW: changing log level of printk for 3 remaining lines makes imho no sense
to implement a debug option (too much overhead).
Peter
--
Dr. Peter Bieringer http://www.bieringer.de/pb/
GPG/PGP Key 0x958F422D mailto: pb at bieringer dot de
Deep Space 6 Co-Founder and Core Member http://www.deepspace6.net/
Attachment:
ves1820-logunified-to-pwmoption.c.diff
Description: Binary data
Attachment:
ves1820-orig-to-logunified.c.diff
Description: Binary data
Attachment:
ves1820-pwmoption-to-afcloglimit.c.diff
Description: Binary data