[linux-dvb] Re: [PATCH] Coding style for skystar2.c (both DVBand dvb-kernel)

[Holger Waechtler <holger@convergence.de>]

Michael Hunold wrote:
> Hello Holger,
>
> > Roberto Ragusa wrote:
> >
> > > On Tue, 25 Nov 2003 08:41:02 +0100
> > > Holger Waechtler <holger@convergence.de> wrote:
> > >
> > >
> > > > Can you please report the oops-log with symbols resolved using 
> > > > ksymoops?
> > >
> > >
> > >
> > > Sorry, I was wrong. The dvb-kernel version works (before and after my 
> > > patch).
> > >
> > > I was stupid enough to manually install skystar2.o from dvb-kernel 
> > > and try
> > > using it with the old dvb-core and others from DVB.
> > >
> > > There was another issue instead, not related to skystar2:
> > > depmod -a -e says
> > >   depmod: *** Unresolved symbols in 
> > > /lib/modules/2.4.22-r1/misc/dvb-bt8xx.o
> > >   depmod:         bttv_get_i2c_adap
> > > This function is defined nowhere and used in a
> > >   #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0)
> > > condition.
>
> > You need to apply a bttv patch for older 2.4 kernels or bttv versions. 
> > You find it in the bt8xx driver directory.
>
> It's better to use 2.4.23-rc3 (or rc4 or rc5, rc3 was the last I used) 
> and the bttv driver from 
> http://bytesex.org/snapshot/video4linux-xxxxyyzz.tar.gz, where
> xxxxyyzz is the date of the release.
>
> But this won't affect the skystar driver, though. I recently updated the 
> README.bt8xx to reflect this method, no more patching with newer 2.4 
> kernels necessary.
Maybe we should midify the insmod.sh script so that it loads only the 
drivers for hardware that's actually existent. Something like:

[...]

if test -z `lspci -n | grep (*vendoridfor7146*)` ; then
	# load drivers for saa7146 based cards
	# and the typically uesed frontends for these cards
	;
fi

[...the same for bt8xx, b2c2, USB...]


(don't have the vendor/device ID for SAA7146 cards at hand, hope you get 
the idea - )

Holger



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.