Andreas Oberritter wrote:
On Sun, 2004-02-15 at 10:06, Guido Draheim wrote:
the same patch, but with each $(DEFS) goes an $(ARCH) which allows
to set _additional_ CFLAGS globally while not overriding the default
DEFS in each makefile. Nice for make ARCH=-mpentiumpro or similar
stuff but anything else is okay as well, e.g. -fno-writable-strings
-fstack-check -W -msse2 -fomit-leaf-frame-pointer etc.pp.
Why don't you call make CFLAGS="-foo -bar" CPPFLAGS="-DLALA"
SYSCONFDIR="/etc" which will override the makefile's variables?
Each subdirectory makefile contains its own set of CFLAGS/CPPFLAGS,
so better leave those alone from toplevel make. Actually, I am
already overriding make sysconfdir=%_sysconfdir in the rpm spec.
The extra DEFS-settings make that into -DSYSCONFIGDIR=$(sysconfdir)
within the makefile.
Another solution is to replace "CFLAGS =" by "CFLAGS +=".
Yes. ;-)
-CFLAGS = -g -O2 -W -Wall
+CFLAGS = -g -O2 -W -Wall $(DEFS) $(ARCH)
CPPFLAGS = -I../include
Preprocessor flags ($DEFS) should be put into CPPFLAGS if needed.
Agreed - here is an updated patch that moves DEFS to CPPFLAGS,
in two places there were no CPPFLAGS so far which get introduced.