[linux-dvb] Re: [PATCH] Ultra Light Encapsulation

[Johannes Stezenbach <js@convergence.de>]

Holger Waechtler wrote:
> Michael Hunold wrote:
> >On 03/31/04 11:11, Hilmar Linder wrote:
> >>+#define FEEDTYPE_SEC    0
> >>+#define FEEDTYPE_TS        1

I think these #defines are rather obscure. Why not rename
them to DVB_NET_FEED_MPE and DVB_NET_FEED_ULE?

> >While preparing a new patchset for the 2.6 kernel, it just came to my 
> >mind that this is a binary incompatible change to the Linux DVB v3 API.
> 
> it's binary-backwards-compatible but new applications using this feature 
> might not won't with old drivers. So I'd say it's safe, we extended the 
> API like this before. I'd suggest to add a note in the API docs which 
> suggests to preinitialize this field to the old default setting to 
> ensure defined behaviour.

I haven't checked, but the size of struct dvb_net_if is encoded
into the ioctl number, so to maintain binary backward compatibility
we need to add a struct dvb_net_if_old and NET_ADD_IF_OLD/NET_GET_IF_OLD
(similar to the VIDIOC_*_OLD in videodev2.h), and proper support
in dvb_net.c. Then old binaries would work with the new driver.

Johannes


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.