[linux-dvb] Re: [patch] av7110 - verbose firmware not found

[Johannes Stezenbach <js@convergence.de>]

Hi,

Kenneth Aafløy wrote:
> 
> Here is a patch for av7110.c that is verbose if the firmware file is just not 
> found, displaying a message on where it usually is and where to get it.

>  	ret = request_firmware(&fw, "dvb-ttpci-01.fw", &av7110->dev->pci->dev);
>  	if (ret) {
> -		printk("dvb-ttpci: cannot request firmware!\n");
> +		if (ret == -ENOENT) {
> +			printk(KERN_ERR "dvb-ttpci: could not load firmware,"
> +					" file not found: dvb-ttpci-01.fw\n");
> +			printk(KERN_INFO "dvb-ttpci: usually this should be in"
> +					 " /usr/lib/hotplug/firmware\n");

It's nice that request_firmware() now reports ENOENT if the
hotplug.agent could not find the file. I changed all message levels to
KERN_ERR to avoid that someone seems only a partial error message.

Thanks,
Johannes