[linux-dvb] Re: refactoring

[Andreas Oberritter <obi@linuxtv.org>]

On Tue, 2004-10-05 at 21:45, Andrew de Quincey wrote:
> Quick question about dvb_add_frontend_ioctls() - this is used to intercept the 
> standard frontend ioctl() call (both before and after) so that card-specific 
> processing may be done.
> 
> However, its only ever used to intercept before the DISEQC ioctl so that 
> card-specific DISEQC hardware can be messed with instead of the demodulator's 
> support (if there is any).
> 
> So we've got a whole infrastructure for doing this that is never used beyond 
> this one case (and with the frontend refactoring, is never going to be IMO).
> 
> I'd be inclined to remove it, and just add an extra function call into the 
> DVB-S demodulator structures - card drivers set this to non-NULL if they want 
> to intercept one of the DISEQC calls.

FWIW, it is also used for setting the frequency and for FE_INIT/FE_SLEEP
in our driver for the dbox2. See 
http://cvs.tuxbox.org/cgi-bin/viewcvs.cgi/tuxbox/driver/fp/dbox2_fp_napi.c?rev=1.14&content-type=text/vnd.viewcvs-markup

Regards,
Andreas