Mailing List archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[linux-dvb] Re: stv0299.c code changes in 2.6.9-rc3-bk9
On Sat, 2004-10-09 at 22:43, C.Y.M wrote:
> The following changes have been made in the latest 2.6.9-rc3-bk9 kernel
> sources. Perhaps they should be applied to cvs as well.
>
>
>
>
> ______________________________________________________________________
> --- dvb-kernel/linux/drivers/media/dvb/frontends/stv0299.c.original 2004-10-09 13:19:48.000000000 -0700
> +++ dvb-kernel/linux/drivers/media/dvb/frontends/stv0299.c 2004-10-09 13:26:18.000000000 -0700
> @@ -329,7 +329,7 @@
> static int pll_write (struct i2c_adapter *i2c, u8 addr, u8 *data, int len)
> {
> int ret;
> - struct i2c_msg msg = { addr: addr, .flags = 0, .buf = data, .len = len };
> + struct i2c_msg msg = { .addr: addr, .buf = data, .len = len };
I don't see a benefit in not initializing "flags". It uses random values
now.
>
>
> stv0299_writereg(i2c, 0x05, 0xb5); /* enable i2c repeater on stv0299 */
> @@ -1317,12 +1317,12 @@
> u8 stat [] = { 0 };
> u8 tda6100_buf [] = { 0, 0 };
> int ret;
> - struct i2c_msg msg1 [] = {{ .addr = 0x68, .flags = 0, .buf = rpt, len: 2 },
> + struct i2c_msg msg1 [] = {{ .addr = 0x68, .buf = rpt, .len = 2 },
> { .addr = 0x60, .flags = I2C_M_RD, .buf = stat, .len = 1 }};
> - struct i2c_msg msg2 [] = {{ .addr = 0x68, .flags = 0, .buf = rpt, len: 2 },
> + struct i2c_msg msg2 [] = {{ .addr = 0x68, .buf = rpt, .len = 2 },
> { .addr = 0x61, .flags = I2C_M_RD, .buf = stat, .len = 1 }};
> - struct i2c_msg msg3 [] = {{ .addr = 0x68, .flags = 0, .buf = rpt, len: 2 },
> - { .addr = 0x60, .flags = 0, .buf = tda6100_buf, .len = 2 }};
> + struct i2c_msg msg3 [] = {{ .addr = 0x68, .buf = rpt, .len = 2 },
> + { .addr = 0x60, .buf = tda6100_buf, .len = 2 }};
>
> stv0299_writereg (i2c, 0x01, 0x15);
> stv0299_writereg (i2c, 0x02, 0x30);
Home |
Main Index |
Thread Index