[linux-dvb] Re: DVB driver bug, fixed it (quick hack)

[Johannes Stezenbach <js@linuxtv.org>]

On Wed, Feb 02, 2005 at 10:50:41PM -0800, C.Y.M wrote:
> C.Y.M wrote:
> >--- dvb-kernel/linux/drivers/media/dvb/dvb-core/dmxdev.h.orig	2005-02-02 
> >12:56:38.000000000 -0800
> >+++ dvb-kernel/linux/drivers/media/dvb/dvb-core/dmxdev.h	2005-02-02 
> >12:51:39.000000000 -0800
> >@@ -115,7 +115,7 @@
> >         struct dmx_frontend *dvr_orig_fe;
> > 
> >         struct dmxdev_buffer dvr_buffer;
> >-#define DVR_BUFFER_SIZE (10*188*1024)
> >+#define DVR_BUFFER_SIZE (100*188*1024)
> > 
> > 	struct semaphore mutex;
> > 	spinlock_t lock;
> 
> 
> Assuming the first patch is not correct, would you still recommend 
> increasing the size of this DVR_BUFFER_SIZE?  An increase of 10 to 100 
> seems like a lot. What would be the optimal recommended size?

IMHO: If 1.8MByte buffer space is insufficient, something else
is wrong with your system.

But the real bug is that there is no ioctl to set the dvr buffer
size from userspace (DMX_SET_BUFFER_SIZE does not do it).

Johannes