[vdr] Re: Compile warning with 1.1.3x

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Jan Ekholm wrote:
> 
> Hi,
> 
> While compiling 1.1.3[012] (I think) I get the following warning a few
> times:
> 
> In file included from menu.c:10:
> osd.h:126: warning: `virtual void cOsdObject::Show()' was hidden
> menu.h:157: warning:   by `void cReplayControl::Show(int)'
> 
> It's not too serious, but could be of interest. This is with g++:
> 
> % g++ --version
> g++ (GCC) 3.2.3 20030415 (Debian prerelease)

Strange... I explicitly have set -Woverloaded-virtual in VDR/Makefile
in order to catch that kind of things, but apparently it doesn't work...

Anyway, please try this patch and let me know whether it fixes this:

--- menu.h      2003/05/11 13:43:58     1.55
+++ menu.h      2003/05/24 16:35:52
@@ -50,7 +50,7 @@
 private:
   int timeout;
   static cDisplayVolume *displayVolume;
-  void Show(void);
+  virtual void Show(void);
   cDisplayVolume(void);
 public:
   virtual ~cDisplayVolume();
@@ -154,7 +154,7 @@
   void TimeSearchDisplay(void);
   void TimeSearchProcess(eKeys Key);
   void TimeSearch(void);
-  void Show(int Seconds = 0);
+  void ShowTimed(int Seconds = 0);
   static char *fileName;
   static char *title;
   void DisplayAtBottom(const char *s = NULL);
@@ -169,6 +169,7 @@
   cReplayControl(void);
   virtual ~cReplayControl();
   virtual eOSState ProcessKey(eKeys Key);
+  virtual void Show(void);
   virtual void Hide(void);
   bool Visible(void) { return visible; }
   static void SetRecording(const char *FileName, const char *Title);
--- menu.c      2003/05/16 12:40:12     1.245
+++ menu.c      2003/05/24 16:35:34
@@ -3240,7 +3240,7 @@
      }
 }

-void cReplayControl::Show(int Seconds)
+void cReplayControl::ShowTimed(int Seconds)
 {
   if (modeOnly)
      Hide();
@@ -3250,6 +3250,11 @@
      }
 }

+void cReplayControl::Show(void)
+{
+  ShowTimed();
+}
+
 void cReplayControl::Hide(void)
 {
   if (visible) {
@@ -3447,7 +3452,7 @@
         marks.Del(m);
      else {
         marks.Add(Current);
-        Show(2);
+        ShowTimed(2);
         }
      marks.Save();
      }


Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.