[vdr] Re: VDR version 1.2.6pre2 pre-release

[Oliver Endriss <o.endriss@gmx.de>]

On Sunday 19 October 2003 14:05, Klaus Schmidinger wrote:
> There has been a small improvement to the still picture function,
> so here's another pre-release.
> 
> Before I upload the official 1.2.6 release I would appreciate if some of
> you could find the time to look over this one in the VDR Developer directory.

During cutting I found a bug in the StillPicture() function.
Sometimes the lower part of the picture is not displayed correctly.
One of the range checks introduced in 1.2.6pre2 causes valid data to be
dropped. Please apply the following patch.

--- dvbdevice.c.org	Sun Oct 19 21:54:32 2003
+++ dvbdevice.c	Sun Oct 19 21:53:09 2003
@@ -963,7 +963,7 @@ void cDvbDevice::StillPicture(const ucha
                     offs += Data[i + 8];
                     len -= 3;
                     len -= Data[i + 8];
-                    if (len < 0 || offs + len >= Length)
+                    if (len < 0 || offs + len > Length)
                        break;
                     }
                  else {

BTW, now we know that the decoder handles missing data gracefully.

Oliver


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.