[vdr] Re: non-transparent osd skin

[Stefan Lucke <stefan@lucke.in-berlin.de>]

On Montag, 18. Oktober 2004 19:28, Nicolas Huillard wrote:
> Torgeir Veimo a écrit :

[ .. ]

> > 
> > This is for creating a plugin that replaces the built in VDR osd?
> > 
> > I tried a simpler approach by just dithering in softdevice's Xv output
> > class just before the OSD is drawn using X calls. There's a check to
> > counter jagged edges for fonts as well, but it creates a shadow to the
> > right of solid areas as well. 
> 
> That the right approach, WRT VDR, but on the softdevice front, you 
> shloud implement that in output-method independent class, in order to 
> share this code between the different methods that need it (FB, Xv, 
> maybe Vidix, and definitely DirectFB, even though DirectFB should do 
> transparent OSD - I can't make it work for now).

Yep, video.c should be the right place and it should be selectable via
OSD.

> So :
> * each output method class should select if it needs this dithering code
> * the base class sould implement the dithering
> * the actual Flush method should call it if needed : either the 
> effective class calls the dither method, or the base method relies on an 
> boolean set by the effective instance.
> 
> BTW : do you know the performance impact of this patch ?

Didn't noticed any performance impact :-) .


Stefan Lucke