[vdr] Re: solved: segment faults from osdtelext plugin

["C.Y.M" <syphir@syphir.sytes.net>]

C.Y.M wrote:
> Rainer Zocholl wrote:
>
> > After replacing all obviously/known not thread save clib calls
> > with their thread save counterparts osdteletext now runs!
> >
> > I would not waste any time to investigate which of those
> > calls are the minimum or why the seg faults are caused in detail. 
> > There is no adavantage using non-thread save functions in a 
> > multithreaded environment. The overhead is neglectable.
>
> Excellent work, Rainer. :)
>
> I looked but I couldnt find any of the said thread "unsafe" calls in 
> streamdev.  The only thing I see is this (but it looks like its ok). 
> Maybe just patching vdr will do the trick.. I will let you know.  Thanks!
>
> client/remote.c:        struct tm *time = localtime_r(&tstart, &tm_r);
> client/remote.c:        struct tm *time = localtime_r(&tstart, &tm_r);
> client/remote.c:        time        = localtime_r(&tstop, &tm_r);
> client/remote.c:        struct tm *now = localtime_r(&t, &tm_r);
> client/remote.c:        localtime_r(&FirstDay, &tm_r);
> client/remote.c:  tm tm = *localtime_r(&t, &tm_r);
> client/remote.c:  return localtime_r(&t, &tm_r)->tm_mday;
> client/remote.c:  int weekday = localtime_r(&t, &tm_r)->tm_wday;
> client/remote.c:  tm tm = *localtime_r(&t, &tm_r);
Well, streamdev must still be using some unsafe threading calls because 
the patches that you posted did not help streaming..  I think my next 
move is to start digging in the streamdev code.  Thanks for all your help.

Regards,