[vdr] Re: solved: segment faults from osdtelext plugin (was:Re: Re: Segmentfaults 43)

["C.Y.M" <syphir@syphir.sytes.net>]

Darren Salt wrote:
> I demand that Rainer Zocholl may or may not have written...
>
>
> > After replacing all obviously/known not thread save clib calls
> > with their thread save counterparts osdteletext now runs!
>
> > I would not waste any time to investigate which of those
> > calls are the minimum or why the seg faults are caused in detail.
> > There is no adavantage using non-thread save functions in a
> > multithreaded environment. The overhead is neglectable.
> [snip patch]
>
> I've gone through and recompiled vdr and the plugins which are installed
> here, based on what you've done. Patches attached (note that vdr-remote
> didn't need to be patched).
I have found a few more plugins that require "safe" threading fixes. 
Steamdev, Text2skin, and MP3.  Attached are the following errors after 
poisoning.

MP3 Plugin:

player-mp3.c:720:16: attempt to use poisoned "rand"
make[1]: *** [player-mp3.o] Error 1

Streamdev:

ccache g++ -g -O2 -Wall -Woverloaded-virtual -O2 -c -D_GNU_SOURCE 
-DHAVE_AUTOPID -I../../../include -I../DVB/include -I. -o common.o common.c
In file included from /usr/include/c++/3.3/cwchar:51,
                 from /usr/include/c++/3.3/bits/fpos.h:45,
                 from /usr/include/c++/3.3/iosfwd:49,
                 from /usr/include/c++/3.3/ios:44,
                 from /usr/include/c++/3.3/ostream:45,
                 from /usr/include/c++/3.3/iostream:45,
                 from common.c:6:
/usr/include/c++/3.3/ctime:59:8: attempt to use poisoned "ctime"
/usr/include/c++/3.3/ctime:60:8: attempt to use poisoned "gmtime"
/usr/include/c++/3.3/ctime:61:8: attempt to use poisoned "localtime"
/usr/include/c++/3.3/ctime:75:11: attempt to use poisoned "ctime"
/usr/include/c++/3.3/ctime:76:11: attempt to use poisoned "gmtime"
/usr/include/c++/3.3/ctime:77:11: attempt to use poisoned "localtime"
In file included from /usr/include/c++/3.3/bits/char_traits.h:45,
                 from /usr/include/c++/3.3/ios:46,
                 from /usr/include/c++/3.3/ostream:45,
                 from /usr/include/c++/3.3/iostream:45,
                 from common.c:6:
/usr/include/c++/3.3/cstring:72:8: attempt to use poisoned "strtok"
/usr/include/c++/3.3/cstring:92:11: attempt to use poisoned "strtok"
In file included from /usr/include/c++/3.3/bits/stl_algobase.h:67,
                 from /usr/include/c++/3.3/memory:54,
                 from /usr/include/c++/3.3/string:48,
                 from /usr/include/c++/3.3/bits/locale_classes.h:47,
                 from /usr/include/c++/3.3/bits/ios_base.h:47,
                 from /usr/include/c++/3.3/ios:49,
                 from /usr/include/c++/3.3/ostream:45,
                 from /usr/include/c++/3.3/iostream:45,
                 from common.c:6:
/usr/include/c++/3.3/cstdlib:74:8: attempt to use poisoned "rand"
/usr/include/c++/3.3/cstdlib:108:11: attempt to use poisoned "rand"
make[1]: *** [common.o] Error 1

Text2Skin:

/usr/include/dirent.h:155:23: attempt to use poisoned "readdir"
loader.c:19:31: attempt to use poisoned "readdir"
make[1]: *** [loader.o] Error 1