[linux-dvb] PATCH: Fix corrupted signal strength value in mt352.c

Barry Scott barry.scott at onelan.co.uk
Tue Jul 12 16:54:48 CEST 2005

Patrick Boettcher wrote:

> On Fri, 8 Jul 2005, Barry Scott wrote:
>> Here is a patch to fix two problems with the signal strength value in 
>> the mt352.c frontend:
>> 1. the 4 most significant bits are zeroed - shift and mask wrong way 
>> round
>> 2. Need to align the 12 bits from the registers at the top of the 16 
>> bit returned value
>>  - otherwise the range is not 0 to 0xffff its 0xf000 to 0xffff
> Thanks a lot. Everything looks better now. :)
> For future patches, please add your "Signed-off-by: "-line when you 
> submit patches.
> That's why I have to ask you this time, may I include your 
> "Signed-off-by:"-signature, when committing this change to CVS?
> Thanks for fixing,
> Patrick.
What's a Signed-off-by signature?

Do you mean you wish to add this to the log?

    Signed-off-by: barry.scott at onelan.co.uk

If so yes that is fine.


More information about the linux-dvb mailing list