[linux-dvb] [PATCH] Several compat additions

Trent Piepho xyzzy at speakeasy.org
Thu May 18 01:54:03 CEST 2006


> > >/* only use this if linux/usb.h and linux/input.h have been included *=
/
> > >#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,13) && \
> > >        defined(__LINUX_USB_H) && defined(_INPUT_H)
> > >/* Found in linux/usb_input.h in 2.6.13 */
> > >#define V4LCOMPAT_NO_USB_INPUT
> > >static inline void
> > >usb_to_input_id(const struct usb_device *dev, struct input_id *id)
> > >
> > >I think this version is much nicer, but it means that after the compat
> > >stuff is stripped, there will be an extra #include <linux/usb.h>.


> Em Dom, 2006-05-14 =E0s 17:11 +0200, christophpfister at bluemail.ch
> escreveu:
> > Just a general consideration (I didn't follow this thread, so I may be =
wrong...):
> >
> > If only the order of includes matters, I'd suggest to include linux/usb=
=2Eh
> > and linux/input.h inside compat.h. (That shouldn't bother bother non-us=
b
> > devices.)


On Tue, 16 May 2006, Mauro Carvalho Chehab wrote:
> This seems good. You may include both if kernel<2.6.13.

Sorry, I'm not sure what you mean.  There are two different ways to make
konicawc back compatable here.  Christoph's way won't work, usb.h shouldn't
bother non-usb devices, but it does.  If it worked, that's what I would hav=
e
done in the first place.

I have a different way than my original patch, what is at the top of this
message.  This will work, but after gentree.pl runs there will still be an
extra include in konicawc.c.  Should I submit a patch to do this?



More information about the linux-dvb mailing list