[linux-dvb] Avermedia 777 misbehaves after remote hack merged into v4l-dvb tree

Linus Torvalds torvalds at osdl.org
Mon Nov 13 17:44:16 CET 2006

On Mon, 13 Nov 2006, Michael Krufky wrote:
> Mauro -- that patch needs fixing / more testing before it goes to mainstream...
> Could you please remove that changeset from your git tree before Linus pulls it?

Too late. Already pulled and pushed out.

Looking at the patch, one obvious bug stands out: the new case statement 
for SAA7134_BOARD_AVERMEDIA_777 doesn't have a "break" at the end.

José, can you test this trivial patch and see if it fixes things?


diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index 7f62403..dee8355 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -202,6 +202,7 @@ int saa7134_input_init1(struct saa7134_d
 		/* Without this we won't receive key up events */
 		saa_setb(SAA7134_GPIO_GPMODE1, 0x1);
 		saa_setb(SAA7134_GPIO_GPSTATUS1, 0x1);
+		break;
 		ir_codes     = ir_codes_pixelview;
 		mask_keycode = 0x00001f;

More information about the linux-dvb mailing list