[linux-dvb] [PATCH] (Try 2) Convert GP8PSK module to use S2API
janne-dvb at grunau.be
Wed Dec 17 21:31:11 CET 2008
On Tuesday 16 December 2008 18:59:04 Alan Nisota wrote:
> Janne, Thanks for your' response. Hopefuly this patch addresses all of
> your concerns.
yes, patch looks fine
> I am not including the API changes at the moment. I'll try again on
> that after this gets committed (the number of folks working with DCII is
> very small, as far as I'm aware, so the other modulation types can be
> handled later)
I've only limited knowledge of DVB-S so I can't really say much about it.
Your original change might be better than my suggestions.
> There were a fewquestions which I'll try to answer here as well:
> > Do the values for the FEC in cmd depend on the
> > modulation?
> Yes, each modulation can have completely different meanings for cmd
ugly but ok. I just wanted to make sure it's correct.
> > I would prefer a S2API command DTV_TURBO_MODES over duplicating
> > modulations. Especially since the the implemtation in the driver
> > differs only for QPSK and QPSK_TURBO.
> The downside to this is that it requires more changes inside of the
> user-space software to do something special with these modulations.
> They really are completely different than non-turbo modes. But as the
> only interesting case is Turbo-QPSK, and I'm not sure which satellites
> even broadcast it, that may be ok.
It seemed wasteful to add 7 new modulations which might be only supported by
a single frontend. Especially if we add the FE_CAN_X flags.
I would like someone else to look at the API changes. I'll send a merge
request for this patch to the v4l-dvb maintainer. Thanks for the patch.
More information about the linux-dvb