[linux-dvb] patch for saa7146_core.c non-module-compile fix included. was Re: Fujtisu Siemens / SuSE 8.1

[fbdev@axion.demon.nl]

Hello Lothar,

I hereby send you a patch to make the saa7146 driver compile as built in driver.
I got it to decode mpeg with mplayer, the only problem I have gotton is that I my board does not have the analogue module on it, so it will not tune anything but analog channels. I have also found the pdf booklet ( I can mail it to you if you want. ) But here is a patch to fix the driver.


--- linux/drivers/media/dvb/av7110/saa7146_core.c	2003-03-17 22:44:22.000000000 +0100
+++ linux/drivers/media/dvb/av7110/saa7146_core.c	2003-03-19 15:26:24.000000000 +0100
@@ -908,7 +908,7 @@
 	.name		= "saa7146",
 	.id_table	= saa7146_pci_tbl,
 	.probe		= saa7146_init_one,
-	.remove		= saa7146_remove_one,
+	.remove		= __devexit_p(saa7146_remove_one),
 	.suspend	= saa7146_suspend,
 	.resume		= saa7146_resume,
 };

I will also attache it.

Monchi.
--
On Mon, Mar 03, 2003 at 07:22:05PM +0100, Lothar Liebig wrote:
> Hello Monchi,
> 
> sorry, haven't tested it any further, too much work and private stuff. Maybe 
> there are a few things I havn't tried yet:
> 
> Install original Kernel Source (  /usr/src/linux/ is a link to the SuSE 
> Kernel, so you should remove the link before installing the Kernel - look at 
> Suse SDB or Google to be sure)
> 
> zcat /proc/config.gz > .config (to save  the actual configuration)
> 
> make oldconfig (maybe there are a few different things to be taken car of)
> 
> make clean dep bzImage modules modules_install
> 
> you're on your own to install the new compiled kernel with grub or lilo. 
> Hav'nt done that for a while (lilo) or never (grub)
> 
> Remember: Do not overwrite your original Kernel!!!
> 
> check everything twice and off you go!
> 
> Reason: 
> The SuSE kernel is heavily modified, whereas maybe not conform to what 
> linux-tv expects.
> 
> You could try the beta kernel too.
> 
> Did You try the linux-tv installation from the SuSE Disks? It showed a line 
> like "Convergence (c) 1999" (not sure) on the TV which slowly disappeared.
> This was the only thing I could see.
> 
> Where did you buy the card (mine I bought thru ebay from Siemens, Kiel)?
> 
> Hope you will get it to work and please mail if there is any progress!
> 
> Take care
> 
> Lothar
> 
> 
> Am Montag, 3. M?rz 2003 10:31 hat mir fbdev@axion.demon.nl geschrieben:
> > Hello lothar,
> >
> > I am just sending you this message to ask you if you got any replies, I
> > have the same card and can't seem to get it to work either.
> >
> > Monchi.
> > --
> >
> > >hi,
> > >
> > >trying to get this card to work with vdr, I managed to compile
> > >linux-12-08-2002 without errors (as far as I can tell). make insmod does
> > > show this in /var/log/messages:
> > >
> > >Jan  6 06:12:38 linux kernel: Linux video capture interface: v1.00
> > >Jan  6 06:12:41 linux kernel: DVB: registering new adapter
> > >(Siemens/Technotrend/Hauppauge PCI rev1.3).
> > >Jan  6 06:12:41 linux kernel: PCI: Found IRQ 10 for device 00:0f.0
> > >Jan  6 06:12:43 linux kernel: ves1820.c: unknown PLL, please report to
> > ><linuxdvb@linuxtv.org>!!
> > >Jan  6 06:12:45 linux kernel: DVB: AV7111(0) - firm f0240009, rtsl
> > > b0250018, vid 71010068, app 00012502
> > >
> > >which I wanted to report as requested. If there is something I could do
> > > about it by myself (change something in 'ves1820.c', or give more
> > > information, pls send me a personal mail, 'cause I'm not subscribed to
> > > the list (yet)!
> > >
> > >Thx a lot
> > >
> > >Lothar
> > >
> > >
> > >PS: here's some information about the DVB-C card (from the net, not
> > > verified on the card itself) HTH
> > >
> > > chips: saa7146ah, TMX320av7111gfn, cy7c024av, ves1820, tda9819, atmel
> > > 24c16 tuner: CD1516/IH
> > >pcb: BS 03601172 DVB
> > >
> > >
> > >
> > >--
> > >Info:
> > >To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe
> > > linux-dvb" as subject.
> 
--- linux/drivers/media/dvb/av7110/saa7146_core.c	2003-03-17 22:44:22.000000000 +0100
+++ linux/drivers/media/dvb/av7110/saa7146_core.c	2003-03-19 15:26:24.000000000 +0100
@@ -908,7 +908,7 @@
 	.name		= "saa7146",
 	.id_table	= saa7146_pci_tbl,
 	.probe		= saa7146_init_one,
-	.remove		= saa7146_remove_one,
+	.remove		= __devexit_p(saa7146_remove_one),
 	.suspend	= saa7146_suspend,
 	.resume		= saa7146_resume,
 };