[linux-dvb] Re: Losless Section Demux version 1.4

[Ralph Metzler <rjkm@metzlerbros.de>]

Emard writes:
 > > > The old code is broken in boundary conditions, dropping some sections
 > > > that should have been otherwise correctly received.
 > > 
 > > Details?
 > 
 > If e.g. one byte of new section starts at the last byte of TS packet,
 > this section will not be received because the old driver requires at
 > least 2 bytes to be able to predict next section's length. New driver 

That's not true. It does process those bytes and stores them for
further processing until the next packet comes.

 > doesn't need such prediciton. There are also some other conditional 
 > rejections if similar type of circumstances are met in other parts 
 > of the code..

Any similar conditionals (i.e. they are checking for more than 3 bytes to
calculate section length) also do not directly reject any data.

One boundary condition which (really) was not checked correctly is 
when PUSI is set, a previous section ends before the next one but
there also is filling between the end of the previous and the start
(indicated by the offset) of the new one.
That's fixed by changing one "==" to "<=".


Ralph 


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.